Bug 126348 - ScrollingStateNodes should have a reference to the ScrollingStateTree
Summary: ScrollingStateNodes should have a reference to the ScrollingStateTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-31 12:23 PST by Simon Fraser (smfr)
Modified: 2014-01-01 10:23 PST (History)
10 users (show)

See Also:

Attachments
Patch (30.93 KB, patch)
2013-12-31 12:25 PST, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-12-31 12:23:17 PST 
ScrollingStateNodes should have a reference to the ScrollingStateTree
Comment 1 Simon Fraser (smfr) 2013-12-31 12:25:24 PST 
Created attachment 220167 [details]
Patch
Comment 2 Sam Weinig 2013-12-31 22:05:14 PST 
Comment on attachment 220167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220167&action=review

> Source/WebCore/ChangeLog:13
> +        In subclasses access the ScrollingStateTree through a member function.s

Tyop.s

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:147
> +void ScrollingStateTree::addNode(ScrollingStateNode* node)

Could this take a reference?
Comment 3 Simon Fraser (smfr) 2014-01-01 10:23:02 PST 
http://trac.webkit.org/changeset/161191