Bug 126343 - [SOUP] Add stubs for CustomProtocol classes
Summary: [SOUP] Add stubs for CustomProtocol classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Soup
Depends on:
Blocks: 125583
  Show dependency treegraph
 
Reported: 2013-12-31 08:24 PST by Carlos Garcia Campos
Modified: 2014-01-16 23:46 PST (History)
12 users (show)

See Also:


Attachments
Patch (12.44 KB, patch)
2013-12-31 08:29 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated (hopefully correctly) cmake files too (14.08 KB, patch)
2013-12-31 08:46 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Rebased patch (14.10 KB, patch)
2014-01-16 00:16 PST, Carlos Garcia Campos
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-12-31 08:24:56 PST
This will simplify the patch that actually implements custom protocols for soup.
Comment 1 Carlos Garcia Campos 2013-12-31 08:29:38 PST
Created attachment 220162 [details]
Patch
Comment 2 Martin Robinson 2013-12-31 08:31:02 PST
Comment on attachment 220162 [details]
Patch

Soup bits look good to me, but do you mind also updating the CMake files?
Comment 3 Carlos Garcia Campos 2013-12-31 08:46:55 PST
Created attachment 220163 [details]
Updated (hopefully correctly) cmake files too
Comment 4 Carlos Garcia Campos 2014-01-16 00:16:50 PST
Created attachment 221339 [details]
Rebased patch
Comment 5 Gustavo Noronha (kov) 2014-01-16 03:24:49 PST
Comment on attachment 221339 [details]
Rebased patch

Looks right to me!
Comment 6 Carlos Garcia Campos 2014-01-16 23:46:41 PST
Committed r162190: <http://trac.webkit.org/changeset/162190>