Bug 126335 - CStack: the GC should not be assuming any limit on the stack size.
Summary: CStack: the GC should not be assuming any limit on the stack size.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 126320
  Show dependency tree / graph
 
Reported: 2013-12-30 23:30 PST by Mark Lam
Modified: 2014-01-13 17:59 PST (History)
5 users (show)

See Also:

Attachments
the patch. (1.13 KB, patch)
2013-12-30 23:33 PST, Mark Lam 		ggaren: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-12-30 23:30:34 PST 
Patch coming.
Comment 1 Mark Lam 2013-12-30 23:33:27 PST 
Created attachment 220152 [details]
the patch.
Comment 2 Mark Lam 2013-12-30 23:36:10 PST 
Landed in r161175 on the jsCStack branch: <http://trac.webkit.org/r161175>.
Comment 3 Geoffrey Garen 2014-01-02 14:05:32 PST 
Comment on attachment 220152 [details]
the patch.

This ChangeLog doesn't explain why you did what you did, so it doesn't meet the minimum bar for a WebKit patch.
Comment 4 Mark Lam 2014-01-09 12:34:35 PST 
Will add a comment to the ChangeLog to indicate that we removed this assertion because we don't know the proper size of the stack that the span came from, and hence, we are not able to do a meaningful assertion for it here.
Comment 5 Mark Lam 2014-01-13 17:16:29 PST 
(In reply to comment #4)
> Will add a comment to the ChangeLog to indicate that we removed this assertion because we don't know the proper size of the stack that the span came from, and hence, we are not able to do a meaningful assertion for it here.

The following comment was added as part of r161575: <http://trac.webkit.org/r161575>

"We cannot do a meaningful assertion here on the size of the stack span because we don't know the stack bounds that the span came from. Hence, the assertion is now removed."
Comment 6 Mark Lam 2014-01-13 17:59:38 PST 
Per our offline discussion, the added comment was satisfactory.  ChangeLog review status updated in r161934 on the jsCStack branch: <http://trac.webkit.org/r161934>.