Bug 126328 - CStack: Fix JSStack::ensureCapacity() to match LLINT and JIT stack checks
Summary: CStack: Fix JSStack::ensureCapacity() to match LLINT and JIT stack checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 126320
  Show dependency tree / graph
 
Reported: 2013-12-30 21:32 PST by Mark Lam
Modified: 2014-01-02 15:21 PST (History)
5 users (show)

See Also:

Attachments
the patch. (2.60 KB, patch)
2013-12-30 21:36 PST, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-12-30 21:32:04 PST 
JSStack::ensureCapacity() is doing its stack check in a complicated way that can result in it yielding different results than the LLINT and JIT stack checks.  So, we'll simplify this code to do the same single pointer comparison against VM::m_jsStackLimit just like the LLINT and JIT does.

This is a step towards https://bugs.webkit.org/show_bug.cgi?id=126320.
Comment 1 Mark Lam 2013-12-30 21:36:07 PST 
Created attachment 220147 [details]
the patch.
Comment 2 Mark Lam 2013-12-30 21:38:47 PST 
Landed in r161170 on the jsCStack branch: <http://trac.webkit.org/r161170>.
Comment 3 Geoffrey Garen 2014-01-02 13:16:28 PST 
Comment on attachment 220147 [details]
the patch.

r=me
Comment 4 Mark Lam 2014-01-02 15:21:30 PST 
Thanks for the review.  Status updated in r161232: <http://trac.webkit.org/r161232>.