Bug 126327 - Use getc rather than getbyte on older ruby
Summary: Use getc rather than getbyte on older ruby
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://trac.macports.org/ticket/37740
Keywords:
Depends on:
Blocks: 126492
  Show dependency tree / graph
 
Reported: 2013-12-30 21:29 PST by Jeremy Huddleston Sequoia
Modified: 2015-05-10 14:07 PDT (History)
3 users (show)

See Also:

Attachments
patch to check ruby version first (500 bytes, patch)
2013-12-30 21:29 PST, Jeremy Huddleston Sequoia 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Huddleston Sequoia 2013-12-30 21:29:41 PST 
Created attachment 220146 [details]
patch to check ruby version first

You should use getc on older ruby (or update configure to abort if ruby is older than 1.8.7)

Trivial patch attached.
Comment 1 Csaba Osztrogonác 2014-01-13 06:01:03 PST 
Please add changelog and set r? if you would like to ask review.
Comment 2 Filip Pizlo 2014-01-13 11:05:37 PST 
Comment on attachment 220146 [details]
patch to check ruby version first

This looks fine.  Can you prepare-ChangeLog and resubmit the patch?  I'll be happy to r+ with appropriate ChangeLog text.
Comment 3 Csaba Osztrogonác 2014-02-06 08:12:37 PST 
ping
Comment 4 Filip Pizlo 2014-02-06 10:21:01 PST 
(In reply to comment #3)
> ping

Do you want to do the honors and land this with a changelog?  R=me.
Comment 5 Michael Catanzaro 2015-05-10 14:07:57 PDT 
Looks like 1.8.7 is the minimum required nowadays, so closing.