Bug 126326 - [PATCH] webkit-gtk + quartz build fails on X11/xresource.h code dependencies
Summary: [PATCH] webkit-gtk + quartz build fails on X11/xresource.h code dependencies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://trac.macports.org/ticket/39898
Keywords:
Depends on:
Blocks: 126492
  Show dependency treegraph
 
Reported: 2013-12-30 21:21 PST by Jeremy Huddleston Sequoia
Modified: 2015-05-10 14:02 PDT (History)
3 users (show)

See Also:


Attachments
trivial patch (868 bytes, patch)
2013-12-30 21:24 PST, Jeremy Huddleston Sequoia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Huddleston Sequoia 2013-12-30 21:21:58 PST
Issue reported via MacPorts with patch available.  See http://trac.macports.org/ticket/39898 for further information

:info:build In file included from Source/WebCore/bridge/NP_jsobject.cpp:30:
:info:build In file included from ./Source/WebCore/bridge/NP_jsobject.h:31:
:info:build ./Source/WebCore/bridge/npruntime_internal.h:33:14: fatal error: 'X11/Xresource.h' file not found
:info:build     #include <X11/Xresource.h>
:info:build              ^
:info:build In file included from Source/WebCore/bridge/npruntime.cpp:31:
:info:build ./Source/WebCore/bridge/npruntime_internal.h:33:14: fatal error: 'X11/Xresource.h' file not found
:info:build     #include <X11/Xresource.h>
:info:build              ^
:info:build 1 error generated.

When gtk/Quartz is used, X11/Xresource.h is still incorrectly pulled in.

Trivial patch attached.
Comment 1 Jeremy Huddleston Sequoia 2013-12-30 21:24:40 PST
Created attachment 220145 [details]
trivial patch
Comment 2 Csaba Osztrogonác 2014-01-13 06:02:20 PST
Please add changelog and set r? if you would like to ask for review.
Comment 3 Michael Catanzaro 2015-05-10 14:02:33 PDT
I believe this issue is obsolete based on comments in bug #126492. If this issue is still present in 2.8.1 or 2.9.1 please leave a note so we can reopen.