Bug 126323 - Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
Summary: Tools/gtk/generate-feature-defines-files doesn't work with older versions of ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-30 21:10 PST by Jeremy Huddleston Sequoia
Modified: 2014-01-16 06:56 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.04 KB, patch)
2014-01-15 03:49 PST, Éva Balázsfalvi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Huddleston Sequoia 2013-12-30 21:10:59 PST
With Leopard's python (2.5.1), this script fails:

Tools/gtk/generate-feature-defines-files
Tools/gtk/generate-feature-defines-files:13: Warning: 'with' will become a reserved keyword in Python 2.6
  File "Tools/gtk/generate-feature-defines-files", line 13
    with open(feature_defines_overriding_file) as f:
            ^
SyntaxError: invalid syntax

This causes build failures down the line due to missing headers.  You should have this cause an error during configure.
Comment 1 Éva Balázsfalvi 2014-01-15 03:49:56 PST
Created attachment 221256 [details]
Patch
Comment 2 Peter Gal 2014-01-16 01:23:56 PST
LGTM
Comment 3 Csaba Osztrogonác 2014-01-16 06:44:31 PST
Comment on attachment 221256 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-01-16 06:56:52 PST
Comment on attachment 221256 [details]
Patch

Clearing flags on attachment: 221256

Committed r162125: <http://trac.webkit.org/changeset/162125>
Comment 5 WebKit Commit Bot 2014-01-16 06:56:54 PST
All reviewed patches have been landed.  Closing bug.