Stop using ThreadCondition in JSC
Created attachment 220139 [details] Patch
Attachment 220139 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/dfg/DFGWorklist.cpp', u'Source/JavaScriptCore/dfg/DFGWorklist.h', u'Source/JavaScriptCore/heap/CopiedSpace.cpp', u'Source/JavaScriptCore/heap/CopiedSpace.h', u'Source/JavaScriptCore/heap/CopiedSpaceInlines.h', u'Source/JavaScriptCore/heap/GCThread.cpp', u'Source/JavaScriptCore/heap/GCThreadSharedData.cpp', u'Source/JavaScriptCore/heap/GCThreadSharedData.h', u'Source/JavaScriptCore/heap/SlotVisitor.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/JavaScriptCore/heap/GCThreadSharedData.cpp:98: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/heap/GCThreadSharedData.cpp:98: Missing space before { [whitespace/braces] [5] ERROR: Source/JavaScriptCore/heap/GCThreadSharedData.cpp:157: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/heap/CopiedSpace.cpp:237: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/heap/CopiedSpace.cpp:237: Missing space before { [whitespace/braces] [5] ERROR: Source/JavaScriptCore/heap/GCThread.cpp:73: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/heap/GCThread.cpp:79: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/dfg/DFGWorklist.cpp:226: More than one command on the same line [whitespace/newline] [4] Total errors found: 8 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 220139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220139&action=review > Source/JavaScriptCore/dfg/DFGWorklist.h:77 > - void dump(const MutexLocker&, PrintStream&) const; > + void dump(const std::unique_lock<std::mutex>&, PrintStream&) const; This should be a guard_lock<> as it makes it impossible get wrong.