Bug 126295 - REGRESSION (r157443): Search fields with a non-white background don’t have a round bezel
Summary: REGRESSION (r157443): Search fields with a non-white background don’t have a ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: mitz
URL: data:text/html,<input%20type=search%2...
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2013-12-30 10:14 PST by mitz
Modified: 2014-02-14 20:28 PST (History)
12 users (show)

See Also:


Attachments
Revert r157443 (14.63 KB, patch)
2014-02-14 16:44 PST, mitz
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2013-12-30 10:14:06 PST
To reproduce, navigate to the URL. The search field doesn’t have the characteristic pill shape.

This was caused by <http://trac.webkit.org/r157443>, the change made for bug 119967. We can’t just treat search fields as style-able without writing the code to render them properly when styled. Moreover, as this change broke various webpages that (either intentionally or accidentally) applied style to search fields, even when we make them style-able we may need to do so in some a backwards-compatible manner.
Comment 1 mitz 2013-12-30 10:28:27 PST
<rdar://problem/15732820>
Comment 2 mitz 2014-02-14 16:44:06 PST
Created attachment 224264 [details]
Revert r157443
Comment 3 Anders Carlsson 2014-02-14 16:50:48 PST
Comment on attachment 224264 [details]
Revert r157443

View in context: https://bugs.webkit.org/attachment.cgi?id=224264&action=review

> Source/WebCore/rendering/RenderTheme.cpp:688
> +    // FIXME: Uncomment this when making search fields style-able.
> +    // case SearchFieldPart:

Maybe just get rid of the commented out case statement and change the comment to say that SearchFieldPart should be handled here when making search fields style-able?
Comment 4 mitz 2014-02-14 16:55:18 PST
Fixed in <http://trac.webkit.org/r164145>.
Comment 6 mitz 2014-02-14 20:02:41 PST
(In reply to comment #5)
> This broke a test: http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r164149%20(2979)/results.html

Looking into this.
Comment 7 Ryosuke Niwa 2014-02-14 20:23:49 PST
Rebaselined the test in http://trac.webkit.org/changeset/164154 since the pixel result looked just fine.
Comment 8 Ryosuke Niwa 2014-02-14 20:25:35 PST
(In reply to comment #7)
> Rebaselined the test in http://trac.webkit.org/changeset/164154 since the pixel result looked just fine.

Oops, I forgot to add the old results to mac-mountainlion. Doing that now.
Comment 9 Ryosuke Niwa 2014-02-14 20:28:31 PST
Done that in http://trac.webkit.org/changeset/164155.