Bug 126295 – REGRESSION (r157443): Search fields with a non-white background don’t have a round bezel

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

To reproduce, navigate to the URL. The search field doesn’t have the characteristic pill shape.

This was caused by <http://trac.webkit.org/r157443>, the change made for bug 119967. We can’t just treat search fields as style-able without writing the code to render them properly when styled. Moreover, as this change broke various webpages that (either intentionally or accidentally) applied style to search fields, even when we make them style-able we may need to do so in some a backwards-compatible manner.

<rdar://problem/15732820>

Created attachment 224264 [details]
Revert r157443

[Anders Carlsson]

Comment on attachment 224264 [details]
Revert r157443

View in context: https://bugs.webkit.org/attachment.cgi?id=224264&action=review

> Source/WebCore/rendering/RenderTheme.cpp:688
> +    // FIXME: Uncomment this when making search fields style-able.
> +    // case SearchFieldPart:

Maybe just get rid of the commented out case statement and change the comment to say that SearchFieldPart should be handled here when making search fields style-able?

Fixed in <http://trac.webkit.org/r164145>.

[Simon Fraser (smfr)]

This broke a test: http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r164149%20(2979)/results.html

(In reply to comment #5)
> This broke a test: http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r164149%20(2979)/results.html

Looking into this.

[Ryosuke Niwa]

Rebaselined the test in http://trac.webkit.org/changeset/164154 since the pixel result looked just fine.

[Ryosuke Niwa]

(In reply to comment #7)
> Rebaselined the test in http://trac.webkit.org/changeset/164154 since the pixel result looked just fine.

Oops, I forgot to add the old results to mac-mountainlion. Doing that now.

[Ryosuke Niwa]

Done that in http://trac.webkit.org/changeset/164155.