Bug 126287 - [SOUP] Return early in ResourceHandle::receivedCancellation if the load has already cancelled
Summary: [SOUP] Return early in ResourceHandle::receivedCancellation if the load has a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Soup
Depends on:
Blocks:
 
Reported: 2013-12-30 03:41 PST by Carlos Garcia Campos
Modified: 2013-12-31 00:31 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2013-12-30 03:45 PST, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-12-30 03:41:30 PST 
This situation can happen when using the network process, because the ReceivedCancellation message can be received when the resource loader has already been removed, but the authentication challenge still has a reference to the ResourceHandleClient. 

$ WEBKIT_USE_NETWORK_PROCESS=1 Programs/WebKit2APITests/TestAuthentication 
/webkit2/WebKitWebView/authentication-request: OK
/webkit2/WebKitWebView/authentication-cancel: OK
/webkit2/WebKitWebView/authentication-load-cancelled: 
(process:1716): libsoup-CRITICAL **: soup_session_unpause_message: assertion 'item != NULL' failed
OK
/webkit2/WebKitWebView/authentication-failure: OK
/webkit2/WebKitWebView/authentication-no-credential: OK
/webkit2/WebKitWebView/authentication-storage: 
(process:1843): libsoup-CRITICAL **: soup_session_unpause_message: assertion 'item != NULL' failed
Comment 1 Carlos Garcia Campos 2013-12-30 03:45:06 PST 
Created attachment 220106 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-12-31 00:31:03 PST 
Committed r161179: <http://trac.webkit.org/changeset/161179>