Bug 126285 – XML document builder should create render tree asynchronously

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Antti Koivisto]

Remove explicit attach call from the XML parser.

[Antti Koivisto]

Created attachment 220101 [details]
patch

[WebKit Commit Bot]

Attachment 220101 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/fast/table/dynamic-caption-add-before-child-expected.png', u'LayoutTests/platform/mac/fast/table/dynamic-caption-add-before-child-expected.txt', u'LayoutTests/svg/custom/object-no-size-attributes-expected.txt', u'LayoutTests/svg/custom/resource-invalidation-crash-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', '--commit-queue']" exit_code: 1
Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 154, in main
    patch_checker.check(patch)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check
    self._text_file_reader.process_file(file_path=path, line_numbers=None)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 118, in process_file
    lines = self._read_lines(file_path)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 86, in _read_lines
    contents = file.read()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 671, in read
    return self.reader.read(size)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 477, in read
    newchars, decodedbytes = self.decode(data, self.errors)
UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 0: invalid start byte


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 220101 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220101&action=review

r=me

> Source/WebCore/ChangeLog:19
> +            recalc don't start creating new renderers.

doesn't

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:-1035
>      RefPtr<CDATASection> newNode = CDATASection::create(m_currentNode->document(), toString(s, len));
>      m_currentNode->parserAppendChild(newNode.get());
> -    if (m_view)
> -        Style::attachTextRenderer(*newNode);

We don't need to keep 'newNode' valid after appending it anymore, should make it:
m_currentNode->parserAppendChild(newNode.release());

[Antti Koivisto]

https://trac.webkit.org/r161140