WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126279
Interrupted test runs should not count at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126279
Summary
Interrupted test runs should not count at build.webkit.org/dashboard
Alexey Proskuryakov
Reported
2013-12-29 13:31:14 PST
1. When latest test run was interrupted (and thus retried), pending revision count no longer shows up, even though the revisions are logically pending, and buildbot is hard at work. 2. When an older run was interrupted, its revisions count as finished when deciding how many revisions to attribute to the next run. This is also incorrect - if someone broke the build, it could be in either interrupted run or the next one, and it's the next one that is the first to be red. So its popover should display all revisions to blame.
Attachments
proposed patch
(7.67 KB, patch)
2013-12-29 14:43 PST
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2013-12-29 14:43:49 PST
Created
attachment 220092
[details]
proposed patch
Alexey Proskuryakov
Comment 2
2013-12-29 14:43:49 PST
Created attachment 220093
WebKit Commit Bot
Comment 3
2013-12-29 15:49:49 PST
Comment on
attachment 220092
[details]
proposed patch Clearing flags on attachment: 220092 Committed
r161130
: <
http://trac.webkit.org/changeset/161130
>
WebKit Commit Bot
Comment 4
2013-12-29 15:49:50 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug