Bug 126279 - Interrupted test runs should not count at build.webkit.org/dashboard
Summary: Interrupted test runs should not count at build.webkit.org/dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-29 13:31 PST by Alexey Proskuryakov
Modified: 2013-12-29 15:49 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (7.67 KB, patch)
2013-12-29 14:43 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-12-29 13:31:14 PST
1. When latest test run was interrupted (and thus retried), pending revision count no longer shows up, even though the revisions are logically pending, and buildbot is hard at work.

2. When an older run was interrupted, its revisions count as finished when deciding how many revisions to attribute to the next run. This is also incorrect - if someone broke the build, it could be in either interrupted run or the next one, and it's the next one that is the first to be red. So its popover should display all revisions to blame.
Comment 1 Alexey Proskuryakov 2013-12-29 14:43:49 PST
Created attachment 220092 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2013-12-29 14:43:49 PST
Created attachment 220093
Comment 3 WebKit Commit Bot 2013-12-29 15:49:49 PST
Comment on attachment 220092 [details]
proposed patch

Clearing flags on attachment: 220092

Committed r161130: <http://trac.webkit.org/changeset/161130>
Comment 4 WebKit Commit Bot 2013-12-29 15:49:50 PST
All reviewed patches have been landed.  Closing bug.