Bug 126271 - Attempt to fix the build of WebCore's code generator on CMake based system
Summary: Attempt to fix the build of WebCore's code generator on CMake based system
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-28 05:14 PST by Benjamin Poulain
Modified: 2014-01-02 03:41 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2013-12-28 05:18 PST, Benjamin Poulain 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-12-28 05:14:22 PST 
Attempt to fix the build of WebCore's code generator on CMake based system
Comment 1 Benjamin Poulain 2013-12-28 05:18:16 PST 
Created attachment 220073 [details]
Patch
Comment 2 Daniel Bates 2013-12-30 11:16:19 PST 
Comment on attachment 220073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220073&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Attempt to fix the build of WebCore's code generator on CMake based system

Can you elaborate? Do we know what revision broke the build? Or is this more of a correctness issue than a build fix? As of the time of writing, looking at <http://build.webkit.org/console> and the stdio of the compile step on EFL Linux 64-bit Release WK1/WK2 and GTK Linux 64-bit Debug WK1/Release, the bots seem to be building without any JavaScriptCore header-related errors.
Comment 3 Benjamin Poulain 2013-12-30 13:11:25 PST 
(In reply to comment #2)
> (From update of attachment 220073 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220073&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        Attempt to fix the build of WebCore's code generator on CMake based system
> 
> Can you elaborate? Do we know what revision broke the build? Or is this more of a correctness issue than a build fix? As of the time of writing, looking at <http://build.webkit.org/console> and the stdio of the compile step on EFL Linux 64-bit Release WK1/WK2 and GTK Linux 64-bit Debug WK1/Release, the bots seem to be building without any JavaScriptCore header-related errors.

I am trying to fix the build consistency to land https://bugs.webkit.org/show_bug.cgi?id=126185
Comment 4 Benjamin Poulain 2014-01-02 03:41:33 PST 
Committed r161206: <http://trac.webkit.org/changeset/161206>