Bug 126270 - Remove WindowIsVisible
Summary: Remove WindowIsVisible
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
Depends on:
Reported: 2013-12-27 20:19 PST by Gavin Barraclough
Modified: 2014-01-02 14:32 PST (History)
13 users (show)

See Also:

Fix (19.96 KB, patch)
2013-12-27 20:39 PST, Gavin Barraclough
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Fix (23.46 KB, patch)
2013-12-27 22:31 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff
gtk fix (24.18 KB, patch)
2013-12-28 12:56 PST, Gavin Barraclough
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-12-27 20:19:15 PST
We currently track visibility in two ways - ViewState::IsVisible and ViewState::WindowIsVisible. The latter detects that the content is hidden in fewer cases that the former, and as such, the former is always preferable.

This affects the hidden state provided to FocusController::contentAreaDidShowOrHide and to Plugin::windowVisibilityChanged.
Comment 1 Gavin Barraclough 2013-12-27 20:39:44 PST
Created attachment 220068 [details]
Comment 2 WebKit Commit Bot 2013-12-27 20:41:53 PST
Attachment 220068 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/FocusController.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/ViewState.h', u'Source/WebKit2/UIProcess/API/mac/PageClientImpl.h', u'Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm', u'Source/WebKit2/UIProcess/API/mac/WKView.mm', u'Source/WebKit2/UIProcess/PageClient.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/page/FocusController.h:83:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 13 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EFL EWS Bot 2013-12-27 20:49:11 PST
Comment on attachment 220068 [details]

Attachment 220068 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/6597286662504448
Comment 4 Gavin Barraclough 2013-12-27 22:31:15 PST
Created attachment 220070 [details]
Comment 5 WebKit Commit Bot 2013-12-27 22:32:18 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 6 Gavin Barraclough 2013-12-28 12:56:23 PST
Created attachment 220078 [details]
gtk fix
Comment 7 Tim Horton 2014-01-02 11:53:32 PST
Comment on attachment 220078 [details]
gtk fix

View in context: https://bugs.webkit.org/attachment.cgi?id=220078&action=review

> Source/WebCore/ChangeLog:9
> +        The latter detects that the content is hidden in fewer cases that the former, and as such, the

Comment 8 Gavin Barraclough 2014-01-02 14:32:22 PST
fixed in r161228