Bug 126268 - Merge didMoveOnscreen / page visibility to isVisible
Summary: Merge didMoveOnscreen / page visibility to isVisible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-27 16:16 PST by Gavin Barraclough
Modified: 2014-01-02 14:12 PST (History)
2 users (show)

See Also:

Attachments
Early patch for EWS (18.19 KB, patch)
2013-12-27 16:18 PST, Gavin Barraclough 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Fix (25.56 KB, patch)
2013-12-27 22:21 PST, Gavin Barraclough 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-12-27 16:16:19 PST 
The onscreen state most closely tracks view visibility (though currently also tracks a mix of in-window state). Make more consistent, simplify, and move all animation suspension logic to Page, so it can be controlled by the PageThrottler.
Comment 1 Gavin Barraclough 2013-12-27 16:18:17 PST 
Created attachment 220067 [details]
Early patch for EWS
Comment 2 EFL EWS Bot 2013-12-27 16:27:51 PST 
Comment on attachment 220067 [details]
Early patch for EWS

Attachment 220067 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/6298945886093312
Comment 3 Gavin Barraclough 2013-12-27 22:21:03 PST 
Created attachment 220069 [details]
Fix
Comment 4 Tim Horton 2014-01-02 11:51:09 PST 
Comment on attachment 220069 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=220069&action=review

> Source/WebCore/page/Page.cpp:1223
> +    if (isVisible)
> +        m_isPrerender = false;
> +
> +    if (isVisible) {

why are there two if() blocks with the same condition here?

> Source/WebCore/page/Page.cpp:1263
> +        suspendScriptedAnimations();

space above here
Comment 5 Gavin Barraclough 2014-01-02 14:02:50 PST 
Fixed in r161223
Comment 6 Alexey Proskuryakov 2014-01-02 14:12:37 PST 
Build fix in r161224.