Bug 126249 - [EFL][WK2] Remove defaultPageGroupIdentifier not to make the confusion
Summary: [EFL][WK2] Remove defaultPageGroupIdentifier not to make the confusion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-26 16:37 PST by Ryuan Choi
Modified: 2014-01-02 23:44 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.17 KB, patch)
2013-12-26 16:47 PST, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-12-26 16:37:30 PST
ewk_page_group_create always creates new page group,
but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "".
It is unnecessary and just makes the confusion.
Comment 1 Ryuan Choi 2013-12-26 16:47:59 PST
Created attachment 220039 [details]
Patch
Comment 2 Gyuyoung Kim 2013-12-26 16:57:33 PST
Comment on attachment 220039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220039&action=review

> Source/WebKit2/ChangeLog:9
> +        but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "".

How will the identifiers be same with "defaultPageGroupIdentifier" when passing null ?
Comment 3 Ryuan Choi 2013-12-26 17:05:26 PST
Comment on attachment 220039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220039&action=review

>> Source/WebKit2/ChangeLog:9
>> +        but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "".
> 
> How will the identifiers be same with "defaultPageGroupIdentifier" when passing null ?

The identifier of WebPageGroup is just what user passed or generated one if user passed empty string.
But, our previous logic only passed "defaultPageGroupIdentifier" when we passed empty string.

In fact, WebPageGroup uses pageGroupID(generated one) and identifier (string which user passed).
Comment 4 Jinwoo Song 2013-12-29 16:56:51 PST
Comment on attachment 220039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220039&action=review

>>> Source/WebKit2/ChangeLog:9
>>> +        but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "".
>> 
>> How will the identifiers be same with "defaultPageGroupIdentifier" when passing null ?
> 
> The identifier of WebPageGroup is just what user passed or generated one if user passed empty string.
> But, our previous logic only passed "defaultPageGroupIdentifier" when we passed empty string.
> 
> In fact, WebPageGroup uses pageGroupID(generated one) and identifier (string which user passed).

If the same identifier is passed, WebCore's page get same page group identifier even a new WebPageGroup is created.

WebPage.cpp
m_page->setGroupName(m_pageGroup->identifier());

The reason I added "defaultPageGroupIdentifier" was to make pages have same group identifier even though developer did not set the identifier.
But it would be better to remove this default identifier because it conflict the behavior of WebPageGroup.
Comment 5 Gyuyoung Kim 2014-01-02 23:11:18 PST
Comment on attachment 220039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220039&action=review

>>>> Source/WebKit2/ChangeLog:9
>>>> +        but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "".
>>> 
>>> How will the identifiers be same with "defaultPageGroupIdentifier" when passing null ?
>> 
>> The identifier of WebPageGroup is just what user passed or generated one if user passed empty string.
>> But, our previous logic only passed "defaultPageGroupIdentifier" when we passed empty string.
>> 
>> In fact, WebPageGroup uses pageGroupID(generated one) and identifier (string which user passed).
> 
> If the same identifier is passed, WebCore's page get same page group identifier even a new WebPageGroup is created.
> 
> WebPage.cpp
> m_page->setGroupName(m_pageGroup->identifier());
> 
> The reason I added "defaultPageGroupIdentifier" was to make pages have same group identifier even though developer did not set the identifier.
> But it would be better to remove this default identifier because it conflict the behavior of WebPageGroup.

If WebPageGroup already support to generate an unique identifier when passing null as argument, I agree to remove the default identifier.
Comment 6 WebKit Commit Bot 2014-01-02 23:44:19 PST
Comment on attachment 220039 [details]
Patch

Clearing flags on attachment: 220039

Committed r161254: <http://trac.webkit.org/changeset/161254>
Comment 7 WebKit Commit Bot 2014-01-02 23:44:23 PST
All reviewed patches have been landed.  Closing bug.