Bug 126248 - Fix build error on 64bit debug build
Summary: Fix build error on 64bit debug build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-26 16:22 PST by Gyuyoung Kim
Modified: 2013-12-29 16:36 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.23 KB, patch)
2013-12-26 16:23 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-12-26 16:22:06 PST
r161076 used ‘%lli’(for long long int) for int64_t(aka long int). However, in a 64bit compile, int64_t is 'long int', not a 'long long int'. To support both 32bit and 64bit, we use static_cast<long long>.
Comment 1 Gyuyoung Kim 2013-12-26 16:23:19 PST
Created attachment 220038 [details]
Patch
Comment 2 Martin Robinson 2013-12-26 16:26:54 PST
Comment on attachment 220038 [details]
Patch

Is it possible to use PRId64 here ala http://stackoverflow.com/questions/9225567/how-to-print-a-int64-t-type-in-c ?
Comment 3 Gyuyoung Kim 2013-12-26 16:45:16 PST
(In reply to comment #2)
> (From update of attachment 220038 [details])
> Is it possible to use PRId64 here ala http://stackoverflow.com/questions/9225567/how-to-print-a-int64-t-type-in-c ?

I'm not sure if this can be supported by MSVC as well. Besides we may include <inttypes.h> to use it. It seems to me current is better for all platforms.
Comment 4 WebKit Commit Bot 2013-12-29 16:29:34 PST
Comment on attachment 220038 [details]
Patch

Rejecting attachment 220038 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 220038, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5672591746400256
Comment 5 Gyuyoung Kim 2013-12-29 16:36:31 PST
Comment on attachment 220038 [details]
Patch

Clearing flags on attachment: 220038

Committed r161133: <http://trac.webkit.org/changeset/161133>
Comment 6 Gyuyoung Kim 2013-12-29 16:36:38 PST
All reviewed patches have been landed.  Closing bug.