Bug 126247 - WebKitGtk 2 build fails from git
Summary: WebKitGtk 2 build fails from git
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 126241 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-26 14:52 PST by Giovanni Campagna
Modified: 2013-12-28 00:54 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.03 KB, patch)
2013-12-27 15:17 PST, Giovanni Campagna
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Giovanni Campagna 2013-12-26 14:52:58 PST
Since the recent enablement of the NetworkProcess in the standard WebKitGtk build, the build fails because libwebkitgtk2 does not expose NetworkProcessMain (so linking WebKitNetworkProcess fails). This only happens if the symbol filter is enabled, ie if not --enable-developer-mode.

The simple fix is:

diff --git a/Source/autotools/symbols.filter b/Source/autotools/symbols.filter
index a01a00c..81a9725 100644
--- a/Source/autotools/symbols.filter
+++ b/Source/autotools/symbols.filter
@@ -2,6 +2,7 @@
 global:
   webkit_*;
   WebProcessMainGtk;
+  NetworkProcessMain;
   _ZN6WebKit22WebGtkExtensionManager10initializeEPK14OpaqueWKBundlePKv;
   _ZN6WebKit22WebGtkExtensionManager6sharedEv;
 local:

I can prepare a proper patch with the usual conventions, but it looks trivial enough that someone of you can apply it (I don't have commit access anyway).

Thanks!
Comment 1 Zan Dobersek 2013-12-27 01:57:55 PST
Feel free to upload the proper patch, someone else can commit it for you or through the commit queue (the automated commit bot for reviewed patches).
Comment 2 ChangSeok Oh 2013-12-27 07:45:48 PST
*** Bug 126241 has been marked as a duplicate of this bug. ***
Comment 3 ChangSeok Oh 2013-12-27 07:49:35 PST
(In reply to comment #0)
> Since the recent enablement of the NetworkProcess in the standard WebKitGtk build, the build fails because libwebkitgtk2 does not expose NetworkProcessMain (so linking WebKitNetworkProcess fails). This only happens if the symbol filter is enabled, ie if not --enable-developer-mode.
> 
> The simple fix is:
> 
> diff --git a/Source/autotools/symbols.filter b/Source/autotools/symbols.filter
> index a01a00c..81a9725 100644
> --- a/Source/autotools/symbols.filter
> +++ b/Source/autotools/symbols.filter
> @@ -2,6 +2,7 @@
>  global:
>    webkit_*;
>    WebProcessMainGtk;
> +  NetworkProcessMain;
>    _ZN6WebKit22WebGtkExtensionManager10initializeEPK14OpaqueWKBundlePKv;
>    _ZN6WebKit22WebGtkExtensionManager6sharedEv;
>  local:
> 
> I can prepare a proper patch with the usual conventions, but it looks trivial enough that someone of you can apply it (I don't have commit access anyway).

Please go ahead. Sooner is better :)
Comment 4 Giovanni Campagna 2013-12-27 15:17:19 PST
Created attachment 220065 [details]
Patch
Comment 5 WebKit Commit Bot 2013-12-28 00:54:34 PST
Comment on attachment 220065 [details]
Patch

Clearing flags on attachment: 220065

Committed r161110: <http://trac.webkit.org/changeset/161110>
Comment 6 WebKit Commit Bot 2013-12-28 00:54:36 PST
All reviewed patches have been landed.  Closing bug.