Bug 126247 – WebKitGtk 2 build fails from git

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Giovanni Campagna]

Since the recent enablement of the NetworkProcess in the standard WebKitGtk build, the build fails because libwebkitgtk2 does not expose NetworkProcessMain (so linking WebKitNetworkProcess fails). This only happens if the symbol filter is enabled, ie if not --enable-developer-mode.

The simple fix is:

diff --git a/Source/autotools/symbols.filter b/Source/autotools/symbols.filter
index a01a00c..81a9725 100644
--- a/Source/autotools/symbols.filter
+++ b/Source/autotools/symbols.filter
@@ -2,6 +2,7 @@
 global:
   webkit_*;
   WebProcessMainGtk;
+  NetworkProcessMain;
   _ZN6WebKit22WebGtkExtensionManager10initializeEPK14OpaqueWKBundlePKv;
   _ZN6WebKit22WebGtkExtensionManager6sharedEv;
 local:

I can prepare a proper patch with the usual conventions, but it looks trivial enough that someone of you can apply it (I don't have commit access anyway).

Thanks!

[Zan Dobersek]

Feel free to upload the proper patch, someone else can commit it for you or through the commit queue (the automated commit bot for reviewed patches).

[ChangSeok Oh]

*** Bug 126241 has been marked as a duplicate of this bug. ***

[ChangSeok Oh]

(In reply to comment #0)
> Since the recent enablement of the NetworkProcess in the standard WebKitGtk build, the build fails because libwebkitgtk2 does not expose NetworkProcessMain (so linking WebKitNetworkProcess fails). This only happens if the symbol filter is enabled, ie if not --enable-developer-mode.
> 
> The simple fix is:
> 
> diff --git a/Source/autotools/symbols.filter b/Source/autotools/symbols.filter
> index a01a00c..81a9725 100644
> --- a/Source/autotools/symbols.filter
> +++ b/Source/autotools/symbols.filter
> @@ -2,6 +2,7 @@
>  global:
>    webkit_*;
>    WebProcessMainGtk;
> +  NetworkProcessMain;
>    _ZN6WebKit22WebGtkExtensionManager10initializeEPK14OpaqueWKBundlePKv;
>    _ZN6WebKit22WebGtkExtensionManager6sharedEv;
>  local:
> 
> I can prepare a proper patch with the usual conventions, but it looks trivial enough that someone of you can apply it (I don't have commit access anyway).

Please go ahead. Sooner is better :)

[Giovanni Campagna]

Created attachment 220065 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 220065 [details]
Patch

Clearing flags on attachment: 220065

Committed r161110: <http://trac.webkit.org/changeset/161110>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.