Bug 126234 - Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible
Summary: Some links at build.webkit.org/dashboard don't show status messages, and aren...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-25 15:04 PST by Alexey Proskuryakov
Modified: 2013-12-26 11:17 PST (History)
1 user (show)

See Also:

Attachments
proposed fix (6.41 KB, patch)
2013-12-25 15:17 PST, Alexey Proskuryakov 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-12-25 15:04:56 PST 
I think that we could use <a> for links, not <div>.
Comment 1 Alexey Proskuryakov 2013-12-25 15:17:29 PST 
Created attachment 220004 [details]
proposed fix

I think that this makes the code noticeably simpler, although I do not know if forcing display:block is a good idea.

Without display:block, the label line becomes a few pixels higher, breaking layout. Is there another way around that?
Comment 2 Alexey Proskuryakov 2013-12-26 11:17:07 PST 
Committed <http://trac.webkit.org/r161092>.