RESOLVED FIXED 126230
[Nix] Adding createDragImageIconForCachedImageFilename method to DragImageNix 
https://bugs.webkit.org/show_bug.cgi?id=126230
Summary [Nix] Adding createDragImageIconForCachedImageFilename method to DragImageNix
Thiago de Barros Lacerda
Reported 2013-12-25 10:43:40 PST
[Nix] Adding createDragImageIconForCachedImageFilename to DragImageNix
Attachments
Patch (1.25 KB, patch)
2013-12-25 10:46 PST, Thiago de Barros Lacerda 		dbates: review+
DetailsFormatted DiffDiff
Patch for landing (1.68 KB, patch)
2013-12-25 18:26 PST, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1 2013-12-25 10:46:41 PST
Created attachment 219996 [details] Patch
Daniel Bates
Comment 2 2013-12-25 15:43:06 PST
Comment on attachment 219996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219996&action=review > Source/WebCore/ChangeLog:8 > + No new tests needed. Either remove this line or explain why "no new tests [are] needed". It seems obvious that no new tests are needed as this patch is adding a function that is materially consistent with an empty function. > Source/WebCore/platform/nix/DragImageNix.cpp:73 > + return 0; Nit: 0 => nullptr
Thiago de Barros Lacerda
Comment 3 2013-12-25 18:26:35 PST
Created attachment 220018 [details] Patch for landing
WebKit Commit Bot
Comment 4 2013-12-25 19:00:21 PST
Comment on attachment 220018 [details] Patch for landing Clearing flags on attachment: 220018 Committed r161081: <http://trac.webkit.org/changeset/161081>
Philippe Normand
Comment 5 2013-12-26 01:38:00 PST
This can be closed I suppose.
Note You need to log in before you can comment on or make changes to this bug.