Bug 126230 - [Nix] Adding createDragImageIconForCachedImageFilename method to DragImageNix
Summary: [Nix] Adding createDragImageIconForCachedImageFilename method to DragImageNix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago de Barros Lacerda
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-25 10:43 PST by Thiago de Barros Lacerda
Modified: 2013-12-26 01:38 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.25 KB, patch)
2013-12-25 10:46 PST, Thiago de Barros Lacerda 		dbates: review+
Details | Formatted Diff | Diff
Patch for landing (1.68 KB, patch)
2013-12-25 18:26 PST, Thiago de Barros Lacerda 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago de Barros Lacerda 2013-12-25 10:43:40 PST 
[Nix] Adding createDragImageIconForCachedImageFilename to DragImageNix
Comment 1 Thiago de Barros Lacerda 2013-12-25 10:46:41 PST 
Created attachment 219996 [details]
Patch
Comment 2 Daniel Bates 2013-12-25 15:43:06 PST 
Comment on attachment 219996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219996&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests needed.

Either remove this line or explain why "no new tests [are] needed". It seems obvious that no new tests are needed as this patch is adding a function that is materially consistent with an empty function.

> Source/WebCore/platform/nix/DragImageNix.cpp:73
> +    return 0;

Nit: 0 => nullptr
Comment 3 Thiago de Barros Lacerda 2013-12-25 18:26:35 PST 
Created attachment 220018 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2013-12-25 19:00:21 PST 
Comment on attachment 220018 [details]
Patch for landing

Clearing flags on attachment: 220018

Committed r161081: <http://trac.webkit.org/changeset/161081>
Comment 5 Philippe Normand 2013-12-26 01:38:00 PST 
This can be closed I suppose.