Bug 126229 – [Nix] Fixing DragData::asFragment signature in DragDataNix.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Thiago de Barros Lacerda]

[Nix] Fixing DragData::asFragment signature in DragDataNix.cpp

[Thiago de Barros Lacerda]

Created attachment 219995 [details]
Patch

[Daniel Bates]

Comment on attachment 219995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219995&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests needed.

Either remove this line or explain why "no new tests [are] needed". It seems obvious that no new tests are needed as this patch is a build fix.

> Source/WebCore/platform/nix/DragDataNix.cpp:90
>      return 0;

Nit: 0 => nullptr

[Thiago de Barros Lacerda]

(In reply to comment #2)
> (From update of attachment 219995 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219995&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests needed.
> 
> Either remove this line or explain why "no new tests [are] needed". It seems obvious that no new tests are needed as this patch is a build fix.

OK

> 
> > Source/WebCore/platform/nix/DragDataNix.cpp:90
> >      return 0;
> 
> Nit: 0 => nullptr

OK

[Thiago de Barros Lacerda]

Created attachment 220017 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 220017 [details]
Patch for landing

Clearing flags on attachment: 220017

Committed r161080: <http://trac.webkit.org/changeset/161080>