Bug 126229 - [Nix] Fixing DragData::asFragment signature in DragDataNix.cpp
Summary: [Nix] Fixing DragData::asFragment signature in DragDataNix.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago de Barros Lacerda
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-25 10:39 PST by Thiago de Barros Lacerda
Modified: 2013-12-26 01:58 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2013-12-25 10:41 PST, Thiago de Barros Lacerda 		dbates: review+
Details | Formatted Diff | Diff
Patch for landing (1.32 KB, patch)
2013-12-25 18:19 PST, Thiago de Barros Lacerda 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago de Barros Lacerda 2013-12-25 10:39:34 PST 
[Nix] Fixing DragData::asFragment signature in DragDataNix.cpp
Comment 1 Thiago de Barros Lacerda 2013-12-25 10:41:21 PST 
Created attachment 219995 [details]
Patch
Comment 2 Daniel Bates 2013-12-25 15:39:19 PST 
Comment on attachment 219995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219995&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests needed.

Either remove this line or explain why "no new tests [are] needed". It seems obvious that no new tests are needed as this patch is a build fix.

> Source/WebCore/platform/nix/DragDataNix.cpp:90
>      return 0;

Nit: 0 => nullptr
Comment 3 Thiago de Barros Lacerda 2013-12-25 18:18:48 PST 
(In reply to comment #2)
> (From update of attachment 219995 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219995&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests needed.
> 
> Either remove this line or explain why "no new tests [are] needed". It seems obvious that no new tests are needed as this patch is a build fix.

OK

> 
> > Source/WebCore/platform/nix/DragDataNix.cpp:90
> >      return 0;
> 
> Nit: 0 => nullptr

OK
Comment 4 Thiago de Barros Lacerda 2013-12-25 18:19:36 PST 
Created attachment 220017 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2013-12-25 18:54:24 PST 
Comment on attachment 220017 [details]
Patch for landing

Clearing flags on attachment: 220017

Committed r161080: <http://trac.webkit.org/changeset/161080>