Display how large the queue is. In the future, I'd like to add more information, like perhaps longest wait time, or to detect and report bots that became dysfunctional.
Created attachment 219985 [details] proposed patch
Created attachment 219987 [details] screenshot
Comment on attachment 219985 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=219985&action=review Looks sane but Tim should probably review this patch. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:67 > + var status = new StatusLineView(message, StatusLineView.Status.Neutral, null, patchCount != 0 ? patchCount : "0", queue.statusPage); Why can't we use patchCount instead of 'patchCount != 0 ? patchCount : "0"'? If anything we should be able to do 'patchCount || "0"'. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:67 > + var platform = categorizedQueuesByPlatformAndBuildType[queue.platform]; > + if (!platform) > + platform = categorizedQueuesByPlatformAndBuildType[queue.platform] = {}; Might be cleaner to do: var platform = categorizedQueuesByPlatformAndBuildType[queue.platform] || {}; categorizedQueuesByPlatformAndBuildType[queue.platform] = platform; > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:75 > + platformQueues = platform[categoryName]; > + if (!platformQueues) > + platformQueues = platform[categoryName] = []; Ditto.
> If anything we should be able to do 'patchCount || "0"'. Good idea! > Might be cleaner to do: This code matches how it's done earlier in this file.
Comment on attachment 219985 [details] proposed patch I agree with the previous review comments but it is fine as-is.
Committed <http://trac.webkit.org/r161099>.