Bug 126216 - [GTK] [CMake] Clean up generated sources directories
Summary: [GTK] [CMake] Clean up generated sources directories
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 115966
  Show dependency treegraph
 
Reported: 2013-12-24 10:29 PST by Martin Robinson
Modified: 2013-12-25 11:04 PST (History)
6 users (show)

See Also:


Attachments
Patch (32.48 KB, patch)
2013-12-24 12:46 PST, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-12-24 10:29:32 PST
We generate sources into inconsistent directories with forwarding headers into several places. We should clean up these directories so that we have:

DerivedSources/InjectedBundle/
DerivedSources/JavaScriptCore/
DerivedSources/MiniBrowser/
DerivedSources/WebCore/
DerivedSources/webkit
DerivedSources/WebKit2/
DerivedSources/webkit2gtk/
DerivedSources/webkitdom/

DerivedSources/ForwardingHeaders/JavaScriptCore
DerivedSources/ForwardingHeaders/WebCore
DerivedSources/ForwardingHeaders/WebKit2
DerivedSources/ForwardingHeaders/webkit2gtk
DerivedSources/ForwardingHeaders/webkit2gtk-webextension

Forwarding header directories can be shared by all targets that need forwarding headers.
Comment 1 Martin Robinson 2013-12-24 12:46:11 PST
Created attachment 219976 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-24 12:48:14 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2013-12-24 12:48:24 PST
Attachment 219976 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u'Source/WebCore/PlatformGTK.cmake', u'Source/WebKit/ChangeLog', u'Source/WebKit/PlatformGTK.cmake', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/PlatformGTK.cmake', u'Source/WebKit2/UIProcess/API/gtk/tests/CMakeLists.txt', u'Source/cmake/OptionsGTK.cmake', u'Tools/ChangeLog', u'Tools/DumpRenderTree/PlatformGTK.cmake', u'Tools/GtkLauncher/CMakeLists.txt', u'Tools/MiniBrowser/gtk/CMakeLists.txt', u'Tools/TestWebKitAPI/CMakeLists.txt', u'Tools/TestWebKitAPI/PlatformEfl.cmake', u'Tools/TestWebKitAPI/PlatformGTK.cmake', u'Tools/WebKitTestRunner/CMakeLists.txt', u'Tools/WebKitTestRunner/PlatformEfl.cmake', u'Tools/WebKitTestRunner/PlatformGTK.cmake', u'Tools/gtk/generate-gtkdoc', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/PlatformGTK.cmake:448:  The item "unix/PluginMainUnix.cpp" should be added only once to the list.  [list/duplicate] [5]
ERROR: Source/WebKit2/PlatformGTK.cmake:454:  Alphabetical sorting problem. "PluginProcess/PluginControllerProxy.messages.in" should be before "Shared/Plugins/NPObjectMessageReceiver.messages.in".  [list/order] [5]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Martin Robinson 2013-12-24 12:50:59 PST
(In reply to comment #3)
> Attachment 219976 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u'Source/WebCore/PlatformGTK.cmake', u'Source/WebKit/ChangeLog', u'Source/WebKit/PlatformGTK.cmake', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/PlatformGTK.cmake', u'Source/WebKit2/UIProcess/API/gtk/tests/CMakeLists.txt', u'Source/cmake/OptionsGTK.cmake', u'Tools/ChangeLog', u'Tools/DumpRenderTree/PlatformGTK.cmake', u'Tools/GtkLauncher/CMakeLists.txt', u'Tools/MiniBrowser/gtk/CMakeLists.txt', u'Tools/TestWebKitAPI/CMakeLists.txt', u'Tools/TestWebKitAPI/PlatformEfl.cmake', u'Tools/TestWebKitAPI/PlatformGTK.cmake', u'Tools/WebKitTestRunner/CMakeLists.txt', u'Tools/WebKitTestRunner/PlatformEfl.cmake', u'Tools/WebKitTestRunner/PlatformGTK.cmake', u'Tools/gtk/generate-gtkdoc', '--commit-queue']" exit_code: 1
> ERROR: Source/WebKit2/PlatformGTK.cmake:448:  The item "unix/PluginMainUnix.cpp" should be added only once to the list.  [list/duplicate] [5]
> ERROR: Source/WebKit2/PlatformGTK.cmake:454:  Alphabetical sorting problem. "PluginProcess/PluginControllerProxy.messages.in" should be before "Shared/Plugins/NPObjectMessageReceiver.messages.in".  [list/order] [5]
> Total errors found: 2 in 18 files
> 

These are false positives. I'll clean them up in another patch.
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Martin Robinson 2013-12-25 11:04:06 PST
Comment on attachment 219976 [details]
Patch

Clearing flags on attachment: 219976

Committed r161068: <http://trac.webkit.org/changeset/161068>
Comment 6 Martin Robinson 2013-12-25 11:04:16 PST
All reviewed patches have been landed.  Closing bug.