Bug 126206 - Make clipping path from basic-shapes relative to <box> value
Summary: Make clipping path from basic-shapes relative to <box> value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://dev.w3.org/fxtf/masking/#the-c...
Keywords:
Depends on:
Blocks: 126207
  Show dependency tree / graph
 
Reported: 2013-12-23 23:23 PST by Dirk Schulze
Modified: 2014-01-10 13:26 PST (History)
6 users (show)

See Also:

Attachments
Patch for landing (15.33 KB, patch)
2014-01-02 12:32 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Patch for landing (255.90 KB, patch)
2014-01-02 13:29 PST, Dirk Schulze 		simon.fraser: review+
simon.fraser: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (255.40 KB, patch)
2014-01-10 09:29 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2013-12-23 23:23:03 PST 
Make clipping path from basic-shapes relative to <box> value.
Comment 1 Dirk Schulze 2014-01-02 12:32:45 PST 
Created attachment 220242 [details]
Patch for landing
Comment 2 Dirk Schulze 2014-01-02 13:29:24 PST 
Created attachment 220246 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2014-01-02 13:32:03 PST 
Attachment 220246 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3/masking/clip-path-circle-border-box.html', u'LayoutTests/css3/masking/clip-path-circle-bounding-box.html', u'LayoutTests/css3/masking/clip-path-circle-content-box.html', u'LayoutTests/css3/masking/clip-path-circle-margin-box.html', u'LayoutTests/css3/masking/clip-path-circle-padding-box.html', u'LayoutTests/platform/mac/css3/masking/clip-path-circle-border-box-expected.png', u'LayoutTests/platform/mac/css3/masking/clip-path-circle-border-box-expected.txt', u'LayoutTests/platform/mac/css3/masking/clip-path-circle-bounding-box-expected.png', u'LayoutTests/platform/mac/css3/masking/clip-path-circle-bounding-box-expected.txt', u'LayoutTests/platform/mac/css3/masking/clip-path-circle-content-box-expected.png', u'LayoutTests/platform/mac/css3/masking/clip-path-circle-content-box-expected.txt', u'LayoutTests/platform/mac/css3/masking/clip-path-circle-margin-box-expected.png', u'LayoutTests/platform/mac/css3/masking/clip-path-circle-margin-box-expected.txt', u'LayoutTests/platform/mac/css3/masking/clip-path-circle-padding-box-expected.png', u'LayoutTests/platform/mac/css3/masking/clip-path-circle-padding-box-expected.txt', u'LayoutTests/platform/mac/css3/masking/mask-luminance-png-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/ClipPathOperation.h', u'Source/WebCore/rendering/RenderLayer.cpp', '--commit-queue']" exit_code: 1
Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 154, in main
    patch_checker.check(patch)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check
    self._text_file_reader.process_file(file_path=path, line_numbers=None)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 118, in process_file
    lines = self._read_lines(file_path)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 86, in _read_lines
    contents = file.read()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 671, in read
    return self.reader.read(size)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 477, in read
    newchars, decodedbytes = self.decode(data, self.errors)
UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 0: invalid start byte


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Simon Fraser (smfr) 2014-01-06 11:18:13 PST 
Comment on attachment 220246 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=220246&action=review

> Source/WebCore/rendering/RenderLayer.cpp:3919
> +    if (!rootRelativeBoundsComputed) {
> +        rootRelativeBounds = calculateLayerBounds(paintingInfo.rootLayer, &offsetFromRoot, 0);
> +        rootRelativeBoundsComputed = true;
> +    }

Why did you move this? The changes below don't seem to require it to be moved.
Comment 5 Dirk Schulze 2014-01-10 09:29:41 PST 
Created attachment 220851 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2014-01-10 13:26:02 PST 
Comment on attachment 220851 [details]
Patch for landing

Clearing flags on attachment: 220851

Committed r161669: <http://trac.webkit.org/changeset/161669>
Comment 7 WebKit Commit Bot 2014-01-10 13:26:05 PST 
All reviewed patches have been landed.  Closing bug.