Bug 126204 - CStack Branch: throwExceptionFromCallSlowPathGenerator() shouldn't pop frame
Summary: CStack Branch: throwExceptionFromCallSlowPathGenerator() shouldn't pop frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 126172
  Show dependency tree / graph
 
Reported: 2013-12-23 22:35 PST by Michael Saboff
Modified: 2013-12-24 07:28 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2013-12-23 22:41 PST, Michael Saboff 		fpizlo: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (866.54 KB, application/zip)
2013-12-24 02:53 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (877.11 KB, application/zip)
2013-12-24 03:38 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-12-23 22:35:37 PST 
Given that the calling convention pushes and pops the call frame register, there is no need to pop a call frame in throwExceptionFromCallSlowPathGenerator().
Comment 1 Michael Saboff 2013-12-23 22:36:39 PST 
This bug is responsible for most of the remaining C Stack test failures.
Comment 2 Michael Saboff 2013-12-23 22:41:32 PST 
Created attachment 219957 [details]
Patch

This fixes most of the remaining bugs.
Comment 3 Build Bot 2013-12-24 02:53:45 PST 
Comment on attachment 219957 [details]
Patch

Attachment 219957 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/49048106

New failing tests:
js/dfg-exception.html
js/exception-propagate-from-dfg-to-llint.html
webgl/1.0.1/conformance/misc/instanceof-test.html
fast/canvas/webgl/instanceof-test.html
fast/canvas/webgl/array-unit-tests.html
fast/dom/dom-constructors.html
fast/canvas/webgl/arraybuffer-transfer-of-control.html
js/dom/stack-trace.html
fast/dom/unregister-protocol-handler.html
fast/dom/register-protocol-handler.html
fast/workers/shared-worker-constructor.html
webgl/1.0.1/conformance/typedarrays/array-unit-tests.html
webgl/1.0.2/conformance/misc/instanceof-test.html
js/dom/toString-and-valueOf-override.html
fast/workers/worker-constructor.html
Comment 4 Build Bot 2013-12-24 02:53:46 PST 
Created attachment 219960 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2013-12-24 03:38:55 PST 
Comment on attachment 219957 [details]
Patch

Attachment 219957 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/51288145

New failing tests:
js/dfg-exception.html
js/exception-propagate-from-dfg-to-llint.html
webgl/1.0.1/conformance/misc/instanceof-test.html
fast/canvas/webgl/instanceof-test.html
fast/canvas/webgl/array-unit-tests.html
fast/dom/dom-constructors.html
fast/canvas/webgl/arraybuffer-transfer-of-control.html
js/dom/stack-trace.html
fast/dom/unregister-protocol-handler.html
fast/dom/register-protocol-handler.html
fast/workers/shared-worker-constructor.html
webgl/1.0.1/conformance/typedarrays/array-unit-tests.html
webgl/1.0.2/conformance/misc/instanceof-test.html
js/dom/toString-and-valueOf-override.html
fast/workers/worker-constructor.html
Comment 6 Build Bot 2013-12-24 03:38:56 PST 
Created attachment 219963 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Michael Saboff 2013-12-24 07:28:58 PST 
Committed r161057: <http://trac.webkit.org/changeset/161057>