Bug 126196 - Add the pseudo classes link and any-link to the Selector Code Generator
Summary: Add the pseudo classes link and any-link to the Selector Code Generator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-23 17:47 PST by Benjamin Poulain
Modified: 2013-12-23 19:25 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.67 KB, patch)
2013-12-23 17:48 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-12-23 17:47:56 PST 
Add the pseudo classes link and any-link to the Selector Code Generator
Comment 1 Benjamin Poulain 2013-12-23 17:48:27 PST 
Created attachment 219949 [details]
Patch
Comment 2 Ryosuke Niwa 2013-12-23 18:36:40 PST 
Comment on attachment 219949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219949&action=review

> Source/WebCore/dom/Node.h:566
>      static ptrdiff_t nodeFlagsMemoryOffset() { return OBJECT_OFFSETOF(Node, m_nodeFlags); }
> -    static uint8_t flagIsElement() { return IsElementFlag; }
> +    static int32_t flagIsElement() { return IsElementFlag; }
> +    static int32_t flagIsLink() { return IsLinkFlag; }

It's unfortunate that we have to expose flags... ideally we have some mechanism to assert that the flag condition we're checking is consistent with Node's implementation.
Comment 3 Benjamin Poulain 2013-12-23 19:25:27 PST 
Comment on attachment 219949 [details]
Patch

Clearing flags on attachment: 219949

Committed r161046: <http://trac.webkit.org/changeset/161046>
Comment 4 Benjamin Poulain 2013-12-23 19:25:29 PST 
All reviewed patches have been landed.  Closing bug.