Bug 126192 - Add the experimental CSS code generator files to the remaining build systems
Summary: Add the experimental CSS code generator files to the remaining build systems
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-23 16:46 PST by Benjamin Poulain
Modified: 2013-12-23 19:19 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.70 KB, patch)
2013-12-23 16:46 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (5.25 KB, patch)
2013-12-23 17:56 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-12-23 16:46:16 PST 
Add the experimental CSS code generator files to the remaining build systems
Comment 1 Benjamin Poulain 2013-12-23 16:46:32 PST 
Created attachment 219942 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-23 16:48:13 PST 
Attachment 219942 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/CMakeLists.txt:29:  There should be exactly one empty line instead of 0 between "inspector" and "loader/appcache".  [list/emptyline] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Benjamin Poulain 2013-12-23 17:53:35 PST 
Comment on attachment 219942 [details]
Patch

I am a dumbass, wrong tree.
Comment 4 Benjamin Poulain 2013-12-23 17:56:41 PST 
Created attachment 219950 [details]
Patch
Comment 5 WebKit Commit Bot 2013-12-23 17:59:32 PST 
Attachment 219950 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/CMakeLists.txt:29:  There should be exactly one empty line instead of 0 between "inspector" and "loader/appcache".  [list/emptyline] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Benjamin Poulain 2013-12-23 19:19:50 PST 
Comment on attachment 219950 [details]
Patch

Clearing flags on attachment: 219950

Committed r161044: <http://trac.webkit.org/changeset/161044>
Comment 7 Benjamin Poulain 2013-12-23 19:19:52 PST 
All reviewed patches have been landed.  Closing bug.