Bug 126191 - CStack:Fixed JSStack::disableErrorStackReserve() and JSStack::installTrapsAfterFrame()
Summary: CStack:Fixed JSStack::disableErrorStackReserve() and JSStack::installTrapsAft...
Status: RESOLVED DUPLICATE of bug 126790
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 125849
  Show dependency treegraph
 
Reported: 2013-12-23 16:39 PST by Mark Lam
Modified: 2014-02-13 03:48 PST (History)
5 users (show)

See Also:


Attachments
the patch. (2.45 KB, patch)
2013-12-23 16:45 PST, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-12-23 16:39:49 PST
1. JSStack::disableErrorStackReserve() was wrongly comparing m_end with m_useableTop.  Fixed the comparison.
2. JSStack::installTrapsAfterFrame() is wrongly overwriting the top slow of the top frame.  Fixed to start the traps at the slot below (as in at lower memory than) the top slot in the top frame.
Comment 1 Mark Lam 2013-12-23 16:45:04 PST
Created attachment 219941 [details]
the patch.
Comment 2 Mark Lam 2013-12-23 16:46:50 PST
Landed in r161038 on the jsCStack branch: <http://trac.webkit.org/r161038>.
Comment 3 Filip Pizlo 2013-12-23 16:57:03 PST
Comment on attachment 219941 [details]
the patch.

Is it possible to have tests for this?
Comment 4 Mark Lam 2014-01-13 17:26:36 PST
Both JSStack::disableErrorStackReserve() and JSStack::installTrapsAfterFrame() were removed in r161927: <http://trac.webkit.org/r161927> for https://bugs.webkit.org/show_bug.cgi?id=126790.  This bug is no longer relevant.

*** This bug has been marked as a duplicate of bug 126790 ***
Comment 5 Csaba Osztrogonác 2014-02-13 03:48:55 PST
Comment on attachment 219941 [details]
the patch.

Cleared review? from attachment 219941 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).