Bug 126189 - Add the pseudo class :focus to the Selector Code Generator
Summary: Add the pseudo class :focus to the Selector Code Generator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-23 16:18 PST by Benjamin Poulain
Modified: 2013-12-23 17:19 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.82 KB, patch)
2013-12-23 16:18 PST, Benjamin Poulain 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-12-23 16:18:30 PST 
Add the pseudo class :focus to the Selector Code Generator
Comment 1 Benjamin Poulain 2013-12-23 16:18:46 PST 
Created attachment 219940 [details]
Patch
Comment 2 Ryosuke Niwa 2013-12-23 16:30:36 PST 
Comment on attachment 219940 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219940&action=review

> Source/WebCore/cssjit/SelectorCompiler.cpp:244
> +            m_functionType = std::max(m_functionType, addPseudoType(selector->pseudoType(), fragment.pseudoClasses));

Maybe we should replace std::max with some descriptive inline function?
Or maybe addPseudoType should be a member function of SelectorCodeGenerator that auto-updates m_functionType.
Or it should take m_functionType as an argument?
Comment 3 Benjamin Poulain 2013-12-23 17:19:41 PST 
Committed r161041: <http://trac.webkit.org/changeset/161041>