RESOLVED FIXED 126187
Refactor PutPropertySlot to be aware of custom properties 
https://bugs.webkit.org/show_bug.cgi?id=126187
Summary Refactor PutPropertySlot to be aware of custom properties
Oliver Hunt
Reported 2013-12-23 15:55:13 PST
Refactor PutPropertySlot to be aware of custom properties
Attachments
Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-12-23 16:08:04 PST
Committed r161033: <http://trac.webkit.org/changeset/161033>
Ryosuke Niwa
Comment 2 2013-12-24 00:22:16 PST
Looks like this caused http/tests/security/cross-frame-access-put.html to start to fail: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fcross-frame-access-put.html --- /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/http/tests/security/cross-frame-access-put-expected.txt +++ /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/http/tests/security/cross-frame-access-put-actual.txt @@ -1,5 +1,4 @@ CONSOLE MESSAGE: Blocked a frame with origin "http://localhost:8000" from accessing a frame with origin "http://127.0.0.1:8000". Protocols, domains, and ports must match. -CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. @@ -381,5 +380,6 @@ This test checks cross-frame access security of window attribute setters (rdar://problem/5326791). +PASS: Unable to set property constructor: TypeError: Type error MAIN WINDOW: !!-- Test ended--!!
Alexey Proskuryakov
Comment 3 2013-12-25 15:56:57 PST
Filed bug 126238 (although maybe it would be better to roll out?)
Oliver Hunt
Comment 4 2013-12-25 16:07:49 PST
(In reply to comment #3) > Filed bug 126238 (although maybe it would be better to roll out?) Honestly i don't think i'm going to get to this as soon as i though, so a rollout is probably best :(
WebKit Commit Bot
Comment 5 2013-12-25 16:23:38 PST
Re-opened since this is blocked by bug 126240
Alexey Proskuryakov
Comment 6 2013-12-25 16:28:01 PST
OK, rolled out in <http://trac.webkit.org/changeset/161077>.
Oliver Hunt
Comment 7 2014-01-02 12:52:39 PST
Committed r161220: <http://trac.webkit.org/changeset/161220>
Note You need to log in before you can comment on or make changes to this bug.