RESOLVED FIXED 126186
CStack: Cosmetic: rename JSStack::m_commitEnd to m_commitTop. 
https://bugs.webkit.org/show_bug.cgi?id=126186
Summary CStack: Cosmetic: rename JSStack::m_commitEnd to m_commitTop.
Mark Lam
Reported 2013-12-23 15:26:43 PST
In the JSStack constructor, m_commitEnd is initialized to highAddress() which is the address just above the start of the stack. This is appropriate because no memory has been committed for the stack yet i.e. highAddress() - m_commitEnd should equal 0. When we grow the stack in growSlowCase, we set m_commitEnd to m_commitEnd - delta, where delta is some even multiple of commitSize (some units of page size). This means that if there is memory committed, m_commitEnd would point to an allocatable slot in the stack, not past it. Hence, m_commitEnd should more appropriately be named m_commitTop.
Attachments
the patch. (6.56 KB, patch)
2013-12-23 15:36 PST, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2013-12-23 15:36:05 PST
Created attachment 219937 [details] the patch.
Mark Lam
Comment 2 2013-12-23 15:36:05 PST
Created attachment 219938
Mark Lam
Comment 3 2013-12-23 15:40:02 PST
Landed in r161030 on the jsCStack branch: <http://trac.webkit.org/r161030>.
Geoffrey Garen
Comment 4 2014-01-13 17:41:35 PST
Comment on attachment 219937 [details] the patch. r=me
Mark Lam
Comment 5 2014-01-13 17:58:21 PST
Thanks. Review status updated in r161934 on the jsCStack branch: <http://trac.webkit.org/r161934>.
Note You need to log in before you can comment on or make changes to this bug.