WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126184
CStack: Cosmetic: rename JSStack::m_useableEnd to m_useableTop.
https://bugs.webkit.org/show_bug.cgi?id=126184
Summary
CStack: Cosmetic: rename JSStack::m_useableEnd to m_useableTop.
Mark Lam
Reported
2013-12-23 15:09:00 PST
In JSStack::enableErrorStackReserve() and disableErrorStackReserve(), m_useableEnd is initialize to reservationTop() or reservationTop() + commitSize. Hence, it points to an allocatable slot in the stack, not past it. Naming it m_useableTop is more correct. Will rename.
Attachments
the patch.
(3.64 KB, patch)
2013-12-23 15:12 PST
,
Mark Lam
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2013-12-23 15:12:16 PST
Created
attachment 219935
[details]
the patch.
Mark Lam
Comment 2
2013-12-23 15:14:35 PST
Landed in
r161027
on the jsCStack branch: <
http://trac.webkit.org/r161027
>.
Geoffrey Garen
Comment 3
2014-01-13 17:41:07 PST
Comment on
attachment 219935
[details]
the patch. r=me
Mark Lam
Comment 4
2014-01-13 17:58:03 PST
Thanks. Review status updated in
r161934
on the jsCStack branch: <
http://trac.webkit.org/r161934
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug