Bug 126184 - CStack: Cosmetic: rename JSStack::m_useableEnd to m_useableTop.
Summary: CStack: Cosmetic: rename JSStack::m_useableEnd to m_useableTop.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 125849
  Show dependency tree / graph
 
Reported: 2013-12-23 15:09 PST by Mark Lam
Modified: 2014-01-13 17:58 PST (History)
5 users (show)

See Also:

Attachments
the patch. (3.64 KB, patch)
2013-12-23 15:12 PST, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-12-23 15:09:00 PST 
In JSStack::enableErrorStackReserve() and disableErrorStackReserve(), m_useableEnd is initialize to reservationTop() or reservationTop() + commitSize.  Hence, it points to an allocatable slot in the stack, not past it.  Naming it m_useableTop is more correct.  Will rename.
Comment 1 Mark Lam 2013-12-23 15:12:16 PST 
Created attachment 219935 [details]
the patch.
Comment 2 Mark Lam 2013-12-23 15:14:35 PST 
Landed in r161027 on the jsCStack branch: <http://trac.webkit.org/r161027>.
Comment 3 Geoffrey Garen 2014-01-13 17:41:07 PST 
Comment on attachment 219935 [details]
the patch.

r=me
Comment 4 Mark Lam 2014-01-13 17:58:03 PST 
Thanks.  Review status updated in r161934 on the jsCStack branch: <http://trac.webkit.org/r161934>.