RESOLVED FIXED 126181
CStack: Cosmetic: rename reservationEnd() to reservationTop() 
https://bugs.webkit.org/show_bug.cgi?id=126181
Summary CStack: Cosmetic: rename reservationEnd() to reservationTop()
Mark Lam
Reported 2013-12-23 14:53:22 PST
reservationEnd() computes the end of the stack at the top. The value is computed as: char* reservationEnd = static_cast<char*>(m_reservation.base()); return reinterpret_cast_ptr<Register*>(reservationEnd); Since m_reservation.base() points at a slot of memory that is within the allocatable range of the stack, this function reservationEnd() is inappropriate. Per Geoff's input, "end" usually refers to the slot past the end of a buffer. Calling it "top" is more appropriate. Hence, I will rename it to reservationTop().
Attachments
the patch. (2.89 KB, patch)
2013-12-23 14:57 PST, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2013-12-23 14:57:49 PST
Created attachment 219932 [details] the patch.
Mark Lam
Comment 2 2013-12-23 15:01:18 PST
Landed in r161025 on the jsCStack branch: <http://trac.webkit.org/r161025>.
Mark Lam
Comment 3 2013-12-23 16:50:24 PST
Thanks for the review. Review status updated in r161039: <http://trac.webkit.org/r161039>.
Note You need to log in before you can comment on or make changes to this bug.