Bug 126178 - Use isDocumentFragment() instead of comparing nodeType() with Node::DOCUMENT_FRAGMENT_NODE
Summary: Use isDocumentFragment() instead of comparing nodeType() with Node::DOCUMENT_...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-12-23 13:41 PST by Ryosuke Niwa
Modified: 2013-12-23 14:47 PST (History)
6 users (show)

See Also:

Attachments
Cleanup (2.15 KB, patch)
2013-12-23 13:52 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-12-23 13:41:58 PST 
Inspired by https://chromium.googlesource.com/chromium/blink/+/a622cb80af2bfb0c5d91123cbcfa4fa72a06554c

Node::isDocumentFragment() is faster than nodeType(), which is virtual.
Comment 1 Ryosuke Niwa 2013-12-23 13:52:43 PST 
Created attachment 219930 [details]
Cleanup
Comment 2 WebKit Commit Bot 2013-12-23 14:47:55 PST 
Comment on attachment 219930 [details]
Cleanup

Clearing flags on attachment: 219930

Committed r161024: <http://trac.webkit.org/changeset/161024>
Comment 3 WebKit Commit Bot 2013-12-23 14:47:58 PST 
All reviewed patches have been landed.  Closing bug.