WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126171
Update custom setter implementations to perform type checks
https://bugs.webkit.org/show_bug.cgi?id=126171
Summary
Update custom setter implementations to perform type checks
Oliver Hunt
Reported
2013-12-23 11:34:43 PST
Update custom setter implementations to perform type checks
Attachments
Patch
(98.02 KB, patch)
2013-12-23 11:36 PST
,
Oliver Hunt
dbates
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Oliver Hunt
Comment 1
2013-12-23 11:36:34 PST
Created
attachment 219920
[details]
Patch
Daniel Bates
Comment 2
2013-12-23 11:45:52 PST
Comment on
attachment 219920
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=219920&action=review
This patch looks straightforward to me.
> Source/WebCore/ChangeLog:8 > + Update the bindings codegen for setters so that they perform a real
Nit: codegen => code generator
> Source/WebCore/ChangeLog:9 > + typecheck.
Nit: typecheck => type check
Oliver Hunt
Comment 3
2013-12-23 11:48:31 PST
Committed
r161009
: <
http://trac.webkit.org/changeset/161009
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug