Bug 126171 - Update custom setter implementations to perform type checks
Summary: Update custom setter implementations to perform type checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-23 11:34 PST by Oliver Hunt
Modified: 2013-12-23 11:48 PST (History)
5 users (show)

See Also:

Attachments
Patch (98.02 KB, patch)
2013-12-23 11:36 PST, Oliver Hunt 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-12-23 11:34:43 PST 
Update custom setter implementations to perform type checks
Comment 1 Oliver Hunt 2013-12-23 11:36:34 PST 
Created attachment 219920 [details]
Patch
Comment 2 Daniel Bates 2013-12-23 11:45:52 PST 
Comment on attachment 219920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219920&action=review

This patch looks straightforward to me.

> Source/WebCore/ChangeLog:8
> +        Update the bindings codegen for setters so that they perform a real

Nit: codegen => code generator

> Source/WebCore/ChangeLog:9
> +        typecheck.

Nit: typecheck => type check
Comment 3 Oliver Hunt 2013-12-23 11:48:31 PST 
Committed r161009: <http://trac.webkit.org/changeset/161009>