Bug 126159 – [CSS Blending] Log blending as a layer creation reason in the WI

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Mihai Tica]

The 'blending' reason for compositing should be visible in the WI.

[Radar WebKit Bug Importer]

<rdar://problem/15718597>

[Radar WebKit Bug Importer]

<rdar://problem/15718599>

[Timothy Hatcher]

*** Bug 126706 has been marked as a duplicate of this bug. ***

[Joseph Pecoraro]

I'm working on this now.

[Joseph Pecoraro]

The originator:
<https://webkit.org/b/99200> Add support for blendmode to Core Animation layer

Hasn't landed yet. When it does I'll have a patch.

[Joseph Pecoraro]

Created attachment 220752 [details]
[PATCH] Untested, Saved Draft of Proposed Fix

[Mihai Tica]

(In reply to comment #5)
> The originator:
> <https://webkit.org/b/99200> Add support for blendmode to Core Animation layer
> 
> Hasn't landed yet. When it does I'll have a patch.

Thanks!
The dependency patch has landed, this issue is no longer blocked.

[Joseph Pecoraro]

Created attachment 220858 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 220859 [details]
[IMAGE] Inspecting LayoutTests/css3/compositing/blend-mode-simple.html

[Timothy Hatcher]

Comment on attachment 220858 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=220858&action=review

> Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js:432
> +            addReason(WebInspector.UIString("Element has âblend-modeâ style"));

Why do we use longer and more vague descriptions in WebCore ("due to association with") and in the UI we are more matter of fact?

[WebKit Commit Bot]

Comment on attachment 220858 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 220858

Committed r161673: <http://trac.webkit.org/changeset/161673>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.