Bug 126141 – cStack branch doesn't run navier-stokes because closure calls aren't implemented yet

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

I'll look into it.

[Filip Pizlo]

Created attachment 219918 [details]
the patch

[Michael Saboff]

Comment on attachment 219918 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219918&action=review

r=me with comments.

> Source/JavaScriptCore/jit/JITCall.cpp:147
> +    addPtr(TrustedImm32(-static_cast<ptrdiff_t>(sizeof(CallerFrameAndPC))), stackPointerRegister, regT1);
>      emitGetFromCallFrameHeader64(JSStack::Callee, regT0, regT1);

Why don't you change this to a helper uses SP and takes into account the CallerFrameAndPC bias?

> Source/JavaScriptCore/jit/JITCall.cpp:191
> +    } // SP holds newCallFrame with ArgumentCount initialized.

Change the comment to include that SP is offset by CallerFrameAndPC.

[Filip Pizlo]

(In reply to comment #2)
> (From update of attachment 219918 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219918&action=review
> 
> r=me with comments.
> 
> > Source/JavaScriptCore/jit/JITCall.cpp:147
> > +    addPtr(TrustedImm32(-static_cast<ptrdiff_t>(sizeof(CallerFrameAndPC))), stackPointerRegister, regT1);
> >      emitGetFromCallFrameHeader64(JSStack::Callee, regT0, regT1);
> 
> Why don't you change this to a helper uses SP and takes into account the CallerFrameAndPC bias?

Good point, I can do this in one line already.

> 
> > Source/JavaScriptCore/jit/JITCall.cpp:191
> > +    } // SP holds newCallFrame with ArgumentCount initialized.
> 
> Change the comment to include that SP is offset by CallerFrameAndPC.

Fixed.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/161006