Bug 126128 - [GTK] Build with network process unconditionally
Summary: [GTK] Build with network process unconditionally
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on: 125422
  Show dependency treegraph
Reported: 2013-12-22 02:00 PST by Carlos Garcia Campos
Modified: 2013-12-23 01:04 PST (History)
7 users (show)

See Also:

Patch (6.74 KB, patch)
2013-12-22 02:07 PST, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff
Patch for landing (6.81 KB, patch)
2013-12-23 00:41 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-12-22 02:00:13 PST
The decision to use the network process is made at run time, so we can always build with the network process with no risk. This will help to catch build issues only affecting the network process and will also make a lot easier to work on the network process if we make the decision based on a env variable until we have the proper API.
Comment 1 Carlos Garcia Campos 2013-12-22 02:07:29 PST
Created attachment 219867 [details]
Comment 2 WebKit Commit Bot 2013-12-22 02:09:21 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2013-12-22 02:22:52 PST
I doesn't build because it depends on bug #125422
Comment 4 Carlos Garcia Campos 2013-12-23 00:41:22 PST
Created attachment 219899 [details]
Patch for landing

Patch for EWS, to make sure I haven't broken EFL build
Comment 5 Carlos Garcia Campos 2013-12-23 01:04:29 PST
Committed r160989: <http://trac.webkit.org/changeset/160989>