Bug 126126 - REGRESSION (r160672): Random remote layers are getting shadows
Summary: REGRESSION (r160672): Random remote layers are getting shadows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-21 21:46 PST by Tim Horton
Modified: 2013-12-23 13:06 PST (History)
2 users (show)

See Also:

Attachments
patch (3.15 KB, patch)
2013-12-21 21:59 PST, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-12-21 21:46:23 PST 
In http://trac.webkit.org/changeset/160672, we unconditionally check m_properties.customAppearance in requiresCustomAppearanceUpdateOnBoundsChange without regard for whether it has ever been initialized. This would get us to send an uninitialized custom appearance to the UI process, which could end up requesting a shadow.

I have a patch to initialize lots of things to their CA defaults.
Comment 1 Tim Horton 2013-12-21 21:59:46 PST 
Created attachment 219862 [details]
patch
Comment 2 Tim Horton 2013-12-23 13:06:47 PST 
http://trac.webkit.org/changeset/161013