Bug 126118 - Figure out if node is focusable without requiring renderer
Summary: Figure out if node is focusable without requiring renderer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 126073
  Show dependency tree / graph
 
Reported: 2013-12-21 06:23 PST by Antti Koivisto
Modified: 2014-06-06 14:04 PDT (History)
2 users (show)

See Also:

Attachments
patch (66.35 KB, patch)
2013-12-21 06:57 PST, Antti Koivisto 		kling: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
fix release build (66.58 KB, patch)
2013-12-21 07:55 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (66.43 KB, patch)
2013-12-21 09:43 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-12-21 06:23:16 PST 
It only needs style not renderer. With increased laziness forcing render tree construction for this is getting troublesome.
Comment 1 Antti Koivisto 2013-12-21 06:57:03 PST 
Created attachment 219850 [details]
patch
Comment 2 Andreas Kling 2013-12-21 07:07:47 PST 
Comment on attachment 219850 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219850&action=review

This seems like a pretty good solution. r=me.

> Source/WebCore/dom/Node.cpp:566
> +    if (!document().renderView())
> +        return false;

How about checking !Document::hasLivingRenderTree() here instead?
Comment 3 Build Bot 2013-12-21 07:47:40 PST 
Comment on attachment 219850 [details]
patch

Attachment 219850 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/49668183
Comment 4 Antti Koivisto 2013-12-21 07:55:50 PST 
Created attachment 219851 [details]
fix release build
Comment 5 Antti Koivisto 2013-12-21 09:43:23 PST 
Created attachment 219853 [details]
another
Comment 6 Antti Koivisto 2013-12-21 10:48:55 PST 
https://trac.webkit.org/r160966
Comment 7 Ryosuke Niwa 2014-06-06 14:04:09 PDT 
This patch also fixed https://bugs.webkit.org/show_bug.cgi?id=133371.