Bug 126113 - [CSSRegions] Crash when trying to select content from invalid region
Summary: [CSSRegions] Crash when trying to select content from invalid region
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 57312
  Show dependency tree / graph
 
Reported: 2013-12-20 23:30 PST by Mihnea Ovidenie
Modified: 2013-12-22 10:12 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.42 KB, patch)
2013-12-20 23:41 PST, Mihnea Ovidenie 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihnea Ovidenie 2013-12-20 23:30:55 PST 
After fix for https://bugs.webkit.org/show_bug.cgi?id=120769, positionForPoint for a region attempt to use the associated named flow to perform its task. However, this should happen only when the region is valid. If the region is invalid, part of a region chain, positionForPoint should behave as usual for a block, otherwise it may run into an infinite loop, which eventually leads to a crash.
Comment 1 Mihnea Ovidenie 2013-12-20 23:41:54 PST 
Created attachment 219840 [details]
Patch
Comment 2 Andreas Kling 2013-12-22 09:45:05 PST 
Comment on attachment 219840 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-12-22 10:12:18 PST 
Comment on attachment 219840 [details]
Patch

Clearing flags on attachment: 219840

Committed r160979: <http://trac.webkit.org/changeset/160979>
Comment 4 WebKit Commit Bot 2013-12-22 10:12:20 PST 
All reviewed patches have been landed.  Closing bug.