WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126100
[WK2] Rename WebURL to API::URL
https://bugs.webkit.org/show_bug.cgi?id=126100
Summary
[WK2] Rename WebURL to API::URL
Sam Weinig
Reported
2013-12-20 18:06:02 PST
[WK2] Rename WebURL to API::URL
Attachments
Patch
(39.40 KB, patch)
2013-12-20 18:19 PST
,
Sam Weinig
andersca
: review+
eflews.bot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
(580.11 KB, application/zip)
2013-12-20 23:12 PST
,
Build Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2013-12-20 18:19:28 PST
Created
attachment 219821
[details]
Patch
WebKit Commit Bot
Comment 2
2013-12-20 18:20:55 PST
Attachment 219821
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/API/c/WKSharedAPICast.h', u'Source/WebKit2/Shared/API/c/WKURL.cpp', u'Source/WebKit2/Shared/API/c/cf/WKURLCF.mm', u'Source/WebKit2/Shared/APIURL.h', u'Source/WebKit2/Shared/Cocoa/WKNSURL.h', u'Source/WebKit2/Shared/Cocoa/WKNSURL.mm', u'Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp', u'Source/WebKit2/Shared/UserData.cpp', u'Source/WebKit2/Shared/UserMessageCoders.h', u'Source/WebKit2/Shared/WebArchiveResource.h', u'Source/WebKit2/Shared/WebURL.h', u'Source/WebKit2/UIProcess/WebFrameProxy.cpp', u'Source/WebKit2/UIProcess/WebFrameProxy.h', u'Source/WebKit2/UIProcess/WebIconDatabase.cpp', u'Source/WebKit2/UIProcess/WebIconDatabaseClient.cpp', u'Source/WebKit2/UIProcess/WebIconDatabaseClient.h', u'Source/WebKit2/UIProcess/WebOpenPanelResultListenerProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebKit2/Shared/APIURL.h:26: #ifndef header guard has wrong style, please use: APIURL_h [build/header_guard] [5] ERROR: Source/WebKit2/Shared/Cocoa/WKNSURL.h:34: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
EFL EWS Bot
Comment 3
2013-12-20 20:33:36 PST
Comment on
attachment 219821
[details]
Patch
Attachment 219821
[details]
did not pass efl-wk2-ews (efl-wk2): Output:
http://webkit-queues.appspot.com/results/49708249
Build Bot
Comment 4
2013-12-20 23:12:32 PST
Comment on
attachment 219821
[details]
Patch
Attachment 219821
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/49698085
New failing tests: editing/inserting/insert-br-009.html
Build Bot
Comment 5
2013-12-20 23:12:34 PST
Created
attachment 219839
[details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Sam Weinig
Comment 6
2013-12-21 16:53:41 PST
Committed
r160969
: <
http://trac.webkit.org/changeset/160969
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug