Bug 126097 – [iOS] Upstream WebCore/pdf changes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[David Kilzer (:ddkilzer)]

Created attachment 219814 [details]
Patch

http://webkit.org/b/000000

Reviewed by NOBODY (OOPS!).

* WebCore.xcodeproj/project.pbxproj: Added files to project.
* pdf/ios/PDFDocument.cpp: Added.
(WebCore::PDFDocumentParser::create):
(WebCore::PDFDocumentParser::document):
(WebCore::PDFDocumentParser::PDFDocumentParser):
(WebCore::PDFDocument::createParser):
* pdf/ios/PDFDocument.h: Added.
(WebCore::PDFDocument::create):
(WebCore::PDFDocument::PDFDocument):
---
 4 files changed, 163 insertions(+)

[WebKit Commit Bot]

Attachment 219814 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/pdf/ios/PDFDocument.cpp', u'Source/WebCore/pdf/ios/PDFDocument.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Kilzer (:ddkilzer)]

Created attachment 219815 [details]
Patch

[Tim Horton]

Comment on attachment 219815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219815&action=review

> Source/WebCore/pdf/ios/PDFDocument.cpp:55
> +        // Ignore all calls

What is the point of this class if it does nothing?

> Source/WebCore/pdf/ios/PDFDocument.cpp:60
> +//------------

what is this!

[Build Bot]

Comment on attachment 219815 [details]
Patch

Attachment 219815 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/49668055

New failing tests:
plugins/quicktime-plugin-replacement.html
fast/block/positioning/abspositioned-object-under-split-relpositioned-inline-crash.html

[Build Bot]

Created attachment 219834 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> (From update of attachment 219815 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219815&action=review
> 
> > Source/WebCore/pdf/ios/PDFDocument.cpp:55
> > +        // Ignore all calls
> 
> What is the point of this class if it does nothing?

It's used in Source/WebCore/loader/DocumentWriter.cpp.

> > Source/WebCore/pdf/ios/PDFDocument.cpp:60
> > +//------------
> 
> what is this!

We're upstreaming first, cleaning up second.

[WebKit Commit Bot]

Comment on attachment 219815 [details]
Patch

Clearing flags on attachment: 219815

Committed r161066: <http://trac.webkit.org/changeset/161066>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.