Bug 126094 - Change "threaded scrolling" terminology to "asynchronous scrolling"
Summary: Change "threaded scrolling" terminology to "asynchronous scrolling"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-20 16:16 PST by Simon Fraser (smfr)
Modified: 2013-12-21 14:26 PST (History)
14 users (show)

See Also:

Attachments
Patch (71.84 KB, patch)
2013-12-20 16:24 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-12-20 16:16:49 PST 
Change "threaded scrolling" terminology to "asynchronous scrolling"
Comment 1 Simon Fraser (smfr) 2013-12-20 16:24:06 PST 
Created attachment 219809 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-12-20 16:32:45 PST 
https://trac.webkit.org/r160944
Comment 3 Csaba Osztrogonác 2013-12-21 02:36:48 PST 
(In reply to comment #2)
> https://trac.webkit.org/r160944

FYI: It broke the Apple Windows build.

     1>WebKit.exp : error LNK2001: unresolved external symbol "public: class WTF::String __thiscall WebCore::Page::mainThreadScrollingReasonsAsText(void)" (?mainThreadScrollingReasonsAsText@Page@WebCore@@QAE?AVString@WTF@@XZ)
     1>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKit.dll : fatal error LNK1120: 1 unresolved externals
Comment 4 Tim Horton 2013-12-21 02:53:07 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > https://trac.webkit.org/r160944
> 
> FYI: It broke the Apple Windows build.
> 
>      1>WebKit.exp : error LNK2001: unresolved external symbol "public: class WTF::String __thiscall WebCore::Page::mainThreadScrollingReasonsAsText(void)" (?mainThreadScrollingReasonsAsText@Page@WebCore@@QAE?AVString@WTF@@XZ)
>      1>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKit.dll : fatal error LNK1120: 1 unresolved externals

Didn't that get fixed in http://trac.webkit.org/changeset/160948?
Comment 5 Csaba Osztrogonác 2013-12-21 14:26:46 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > https://trac.webkit.org/r160944
> > 
> > FYI: It broke the Apple Windows build.
> > 
> >      1>WebKit.exp : error LNK2001: unresolved external symbol "public: class WTF::String __thiscall WebCore::Page::mainThreadScrollingReasonsAsText(void)" (?mainThreadScrollingReasonsAsText@Page@WebCore@@QAE?AVString@WTF@@XZ)
> >      1>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKit.dll : fatal error LNK1120: 1 unresolved externals
> 
> Didn't that get fixed in http://trac.webkit.org/changeset/160948?

Maybe yes ... but it seems r160944 broke the Windows build again:
https://bugs.webkit.org/show_bug.cgi?id=126082#c8