Pretty print LayoutUnit, LayoutPoint, and LayoutSize in gdb and lldb
Created attachment 219788 [details] Patch
Comment on attachment 219788 [details] Patch Rejecting attachment 219788 [details] from commit-queue. New failing tests: dom/xhtml/level2/html/HTMLInputElement01.xhtml Full output: http://webkit-queues.appspot.com/results/49708169
Created attachment 219800 [details] Archive of layout-test-results from webkit-cq-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Dear CQ, go home, you're drunk.
(In reply to comment #4) > Dear CQ, go home, you're drunk. Landed manually as r160941.
Does this do the right thing when subpixel is disabled?
(In reply to comment #6) > Does this do the right thing when subpixel is disabled? I don't think so. (and the hardcoded 64 value is not such a great idea either, we might change that in the future)
Re-opened since this is blocked by bug 126095
Created attachment 221581 [details] Patch
There were a few problems with the original patch and I tried to address them in the lldb part 1. LayoutUnit value is signed, the original patch would output incorrect px value for negative LayoutUnits 2. This patch dynamically checks the current subpixel value, so it works when the denominator gets changed or when the subpixel is disabled.
Comment on attachment 221581 [details] Patch Clearing flags on attachment: 221581 Committed r162297: <http://trac.webkit.org/changeset/162297>
All reviewed patches have been landed. Closing bug.