Bug 126068 - Replace virtual isListBox functions with enum and standalone function
Summary: Replace virtual isListBox functions with enum and standalone function
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-20 07:48 PST by Antti Koivisto
Modified: 2013-12-20 08:57 PST (History)
3 users (show)

See Also:

Attachments
patch (22.42 KB, patch)
2013-12-20 07:53 PST, Antti Koivisto 		kling: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (458.88 KB, application/zip)
2013-12-20 08:57 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-12-20 07:48:01 PST 
Fast and modern.
Comment 1 Antti Koivisto 2013-12-20 07:53:27 PST 
Created attachment 219757 [details]
patch
Comment 2 Andreas Kling 2013-12-20 08:00:19 PST 
Comment on attachment 219757 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219757&action=review

> Source/WebCore/ChangeLog:3
> +        Replace virtual isRenderFoo functions with bits and standalone functions

Title seems a bit broad when it's only for RenderListBox so far.
Comment 3 Antti Koivisto 2013-12-20 08:24:53 PST 
> Title seems a bit broad when it's only for RenderListBox so far.

It is an aspirational title!
Comment 4 Build Bot 2013-12-20 08:57:49 PST 
Comment on attachment 219757 [details]
patch

Attachment 219757 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/50568045

New failing tests:
editing/execCommand/format-block-multiple-paragraphs-in-pre.html
Comment 5 Build Bot 2013-12-20 08:57:51 PST 
Created attachment 219761 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5