Bug 126064 - [arm] Missing implementation of branchTest8(ResultCondition, BaseIndex, TrustedImm32) in MacroAssembler
Summary: [arm] Missing implementation of branchTest8(ResultCondition, BaseIndex, Trust...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-20 03:29 PST by Julien Brianceau
Modified: 2013-12-20 07:43 PST (History)
6 users (show)

See Also:

Attachments
Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in macro assembler for CPU(ARM_TRADITIONAL). (1.48 KB, patch)
2013-12-20 03:33 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-12-20 03:29:50 PST 
CPU(ARM_TRADITIONAL) build is broken:

    [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/jit/JITPropertyAccess.cpp.o
    /nuxatlas6/local/jbriance/WebKit/cmake-arm/webkit/Source/JavaScriptCore/jit/JITPropertyAccess.cpp: In member function ‘JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Jump     JSC::JIT::checkMarkWord(JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID)’:
    /nuxatlas6/local/jbriance/WebKit/cmake-arm/webkit/Source/JavaScriptCore/jit/JITPropertyAccess.cpp:885:99: error: no matching function for call to ‘JSC::JIT::branchTest8(JSC::MacroAssemblerARM::ResultCondition, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::BaseIndex)’

A patch similar to http://trac.webkit.org/changeset/160680 is needed for CPU(ARM_TRADITIONAL) architecture.
Comment 1 Julien Brianceau 2013-12-20 03:33:23 PST 
Created attachment 219747 [details]
Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in macro assembler for CPU(ARM_TRADITIONAL).
Comment 2 Mark Hahnenberg 2013-12-20 07:16:44 PST 
Comment on attachment 219747 [details]
Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in macro assembler for CPU(ARM_TRADITIONAL).

r=me
Comment 3 WebKit Commit Bot 2013-12-20 07:43:14 PST 
Comment on attachment 219747 [details]
Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in macro assembler for CPU(ARM_TRADITIONAL).

Clearing flags on attachment: 219747

Committed r160911: <http://trac.webkit.org/changeset/160911>
Comment 4 WebKit Commit Bot 2013-12-20 07:43:16 PST 
All reviewed patches have been landed.  Closing bug.