Bug 126063 - [sh4] Missing implementation of branchTest8(ResultCondition, BaseIndex, TrustedImm32) in MacroAssembler
Summary: [sh4] Missing implementation of branchTest8(ResultCondition, BaseIndex, Trust...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-20 03:16 PST by Julien Brianceau
Modified: 2013-12-20 07:45 PST (History)
4 users (show)

See Also:

Attachments
Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in sh4 macro assembler. (1.55 KB, patch)
2013-12-20 03:20 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-12-20 03:16:05 PST 
sh4 build is broken:

    [ 11%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/jit/JITPropertyAccess.cpp.o
    /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITPropertyAccess.cpp: In member function ‘JSC::AbstractMacroAssembler<JSC::SH4Assembler>::Jump JSC::JIT::checkMarkWord(JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID)’:
    /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITPropertyAccess.cpp:885:99: error: no matching function for call to ‘JSC::JIT::branchTest8(JSC::MacroAssemblerSH4::ResultCondition, JSC::AbstractMacroAssembler<JSC::SH4Assembler>::BaseIndex)’


A patch similar to http://trac.webkit.org/changeset/160680 is needed for sh4 architecture.
Comment 1 Julien Brianceau 2013-12-20 03:20:40 PST 
Created attachment 219746 [details]
Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in sh4 macro assembler.
Comment 2 Mark Hahnenberg 2013-12-20 07:17:14 PST 
Comment on attachment 219746 [details]
Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in sh4 macro assembler.

r=me
Comment 3 WebKit Commit Bot 2013-12-20 07:45:27 PST 
Comment on attachment 219746 [details]
Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in sh4 macro assembler.

Clearing flags on attachment: 219746

Committed r160912: <http://trac.webkit.org/changeset/160912>
Comment 4 WebKit Commit Bot 2013-12-20 07:45:29 PST 
All reviewed patches have been landed.  Closing bug.