Bug 126059 - Build fails in debug mode after r160834.
Summary: Build fails in debug mode after r160834.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-20 00:30 PST by Tamas Gergely
Modified: 2013-12-20 02:49 PST (History)
4 users (show)

See Also:


Attachments
patch (1.28 KB, patch)
2013-12-20 00:42 PST, Tamas Gergely
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Gergely 2013-12-20 00:30:34 PST
Compile error in debug mode:

Source/WTF/wtf/dtoa/double-conversion.cc: In static member function 'static double WTF::double_conversion::StringToDoubleConverter::StringToDouble(const char*, size_t, size_t*)':
Source/WTF/wtf/dtoa/double-conversion.cc:488:33: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
Source/WTF/wtf/dtoa/double-conversion.cc:525:37: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
Source/WTF/wtf/dtoa/double-conversion.cc:596:25: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
Comment 1 Tamas Gergely 2013-12-20 00:42:28 PST
Created attachment 219737 [details]
patch
Comment 2 Csaba Osztrogonác 2013-12-20 02:22:24 PST
Comment on attachment 219737 [details]
patch

LGTM, r=me.
Comment 3 WebKit Commit Bot 2013-12-20 02:49:13 PST
Comment on attachment 219737 [details]
patch

Clearing flags on attachment: 219737

Committed r160899: <http://trac.webkit.org/changeset/160899>
Comment 4 WebKit Commit Bot 2013-12-20 02:49:14 PST
All reviewed patches have been landed.  Closing bug.