Bug 126053 - Add a test for reattaching collapsed whitespace when siblings change style
Summary: Add a test for reattaching collapsed whitespace when siblings change style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-12-19 22:08 PST by Ryosuke Niwa
Modified: 2013-12-24 00:08 PST (History)
4 users (show)

See Also:

Attachments
Adds the test (2.86 KB, patch)
2013-12-19 22:11 PST, Ryosuke Niwa 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-12-19 22:08:29 PST 
Merge the test from https://chromium.googlesource.com/chromium/blink/+/dd5636728643ff958aebeaf064d38754b0d5904b
so that we may not introduce the same regression in WebKit.
Comment 1 Ryosuke Niwa 2013-12-19 22:11:32 PST 
Created attachment 219730 [details]
Adds the test
Comment 2 mitz 2013-12-20 18:36:01 PST 
Comment on attachment 219730 [details]
Adds the test

View in context: https://bugs.webkit.org/attachment.cgi?id=219730&action=review

> LayoutTests/fast/css/collapsed-whitespace-reattach-in-style-recalc.html:31
> +    shouldBeGreaterThanOrEqual('spans[spans.length - 1].offsetLeft', "400");

Is there a way to write this 400 as “more than half the width of ” something?
Comment 3 Ryosuke Niwa 2013-12-24 00:07:46 PST 
(In reply to comment #2)
> (From update of attachment 219730 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219730&action=review
> 
> > LayoutTests/fast/css/collapsed-whitespace-reattach-in-style-recalc.html:31
> > +    shouldBeGreaterThanOrEqual('spans[spans.length - 1].offsetLeft', "400");
> 
> Is there a way to write this 400 as “more than half the width of ” something?

Replaced it with container.offsetWidth * 2 / 3.
Comment 4 Ryosuke Niwa 2013-12-24 00:08:10 PST 
Committed r161052: <http://trac.webkit.org/changeset/161052>